Skip to content

Allow default behaviour of tab key on pagination dots to avoid keyboard trap - #124

Merged
vsseixaso merged 2 commits into
vtex-apps:masterfrom
ailbhebyrne:master
Aug 27, 2025
Merged

vsseixaso merged 2 commits into
vtex-apps:masterfrom
ailbhebyrne:master

Conversation

@ailbhebyrne

Copy link
Copy Markdown
Contributor

What problem is this solving?

For accessibility, users need to be able to move around the site using the keyboard. Preventing the default behaviour of the tab key when the pagination dots are selected meant the user got stuck in a loop. Allowing the default behaviour means the user can jump to the next element.

How to test it?

Workspace

Navigate out of product carousel using the tab key.

@ailbhebyrne
ailbhebyrne requested a review from a team as a code owner August 26, 2025 12:41
@ailbhebyrne
ailbhebyrne requested review from RodrigoTadeuF, gabpaladino and vmourac-vtex and removed request for a team August 26, 2025 12:41
@vtex-io-ci-cd

vtex-io-ci-cd Bot commented Aug 26, 2025 •

Copy link
Copy Markdown

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot

vtex-io-docs-bot Bot commented Aug 26, 2025 •

Copy link
Copy Markdown

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@vsseixaso vsseixaso left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vsseixaso
vsseixaso merged commit 897880f into vtex-apps:master Aug 27, 2025
5 checks passed
@vtex-io-ci-cd

vtex-io-ci-cd Bot commented Aug 27, 2025

Copy link
Copy Markdown

Your PR has been merged! App is being published. 🚀
Version 0.24.7 → 0.24.8

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.slider-layout@0.24.8

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants