Skip to content

fix: add role="region" to flex layout div with aria-label for WCAG 2.2 compliance #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iago1501 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: add role="region" to flex layout div with aria-label for WCAG 2.2 compliance #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
80f19d6
fix: add role="region" to flex layout div with aria-label for WCAG 2.…
iago1501 Jul 3, 2026
5690a2d
fix: restore full CHANGELOG.md history
iago1501 Jul 3, 2026
717fe2d
fix: restore complete CHANGELOG.md with all historical entries
iago1501 Jul 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## [Unreleased]
### Fixed
- Add `role="region"` to flex layout div with aria-label to comply with WCAG 2.2 Level A (4.1.2) and ARIA 1.2 specification

## [0.21.5] - 2025-07-24
+ ### Fixed
Expand Down Expand Up @@ -193,4 +195,4 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

## [0.1.0]
### Added
- `flex-row` and `flex-col` blocks.
- `flex-row` and `flex-col` blocks.
2 changes: 1 addition & 1 deletion react/FlexLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ const FlexLayout: StorefrontFunctionComponent<Props> = props => {
const wrappedContent = shouldUseContainer ? <Container>{content}</Container> : content

return (
<div className={handles.flexRow} id={htmlId} aria-label={arialabel ? arialabel : intl.formatMessage(
<div className={handles.flexRow} id={htmlId} role="region" aria-label={arialabel ? arialabel : intl.formatMessage(
{ id: 'store/flex-layout.flexLayout-row.aria-label' }, { sectionId: htmlId ?? 'row'})}>
{wrappedContent}
</div>
Expand Down
Loading