use expect over allow in clippy#7373
Merged
joseph-isaacs merged 7 commits intodevelopfrom Apr 10, 2026
Merged
Conversation
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk> # Conflicts: # vortex-array/src/patches.rs
The function used MaskMut which was removed in develop (#7379). The merge conflict resolution incorrectly kept this dead function. Signed-off-by: Joe Isaacs <joe@spiraldb.com>
- fuzz/src/lib.rs: unused_mut only needed with cuda+linux feature - vortex-io/src/read_at.rs: cognitive_complexity varies by features Signed-off-by: Joe Isaacs <joe@spiraldb.com>
- avx2.rs: cast_possible_truncation in test macros varies by type param - driver.rs: cognitive_complexity varies by features Signed-off-by: Joe Isaacs <joe@spiraldb.com>
Signed-off-by: Joe Isaacs <joe@spiraldb.com>
0ax1
reviewed
Apr 10, 2026
0ax1
approved these changes
Apr 10, 2026
a10y
approved these changes
Apr 10, 2026
Contributor
|
I expected better, but I'll allow it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes: #000
Testing