Skip to content

ji/remove-double-filter #7315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
joseph-isaacs wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

ji/remove-double-filter #7315

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions vortex-duckdb/src/datasource.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,7 @@ impl<T: DataSourceTableFunction> TableFunction for T {
bind_data: &mut Self::BindData,
expr: &ExpressionRef,
) -> VortexResult<bool> {
tracing::debug!("Attempting to push down filter expression: {expr}");
debug!("Attempting to push down filter expression: {expr}");
let Some(expr) = try_from_bound_expression(expr)? else {
return Ok(false);
};
Expand All @@ -405,7 +405,7 @@ impl<T: DataSourceTableFunction> TableFunction for T {
// If we plumb row count estimation into the layout tree, perhaps we could use zone maps
// etc. to return estimates. But this function is probably called too late anyway. Maybe
// we need our own cardinality heuristics.
Ok(false)
Ok(true)
}

fn cardinality(bind_data: &Self::BindData) -> Cardinality {
Expand Down
Loading