[RFC 33] Add RotorQuant/IsoQuant comparison#45
Merged
lwwmanning merged 1 commit intodevelopfrom Apr 9, 2026
Merged
Conversation
…0033 Incorporate findings from TheTom/turboquant_plus#34, where small block-diagonal rotations (SO(2)/SO(3)/SO(4)) caused 10x+ MSE regressions on real KV-cache data. This empirical evidence strengthens the case for large block sizes (B=256+) in Stage 2 and motivates a new experimental plan item measuring cross-block correlation on real embeddings. https://claude.ai/code/session_016qKqZ579LA83p7ThoAdqut Signed-off-by: Will Manning <will@willmanning.io>
b5a171d to
9ea08f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a comprehensive comparison section between TurboQuant's full-dimension SORF approach and alternative block-diagonal rotation strategies (RotorQuant, IsoQuant, PlanarQuant), along with empirical evidence and additional experimental validation plans.
Key Changes
New comparison section: Added detailed analysis of RotorQuant/IsoQuant approaches that use small-block rotations (SO(2)/SO(3)/SO(4)) vs. TurboQuant's full-dimension SORF
Strengthened decorrelation analysis: Added section in the "Coordinate distribution" discussion that:
Enhanced experimental plan: Extended the block-size testing section with:
Added reference [13]: Documented RotorQuant/IsoQuant work with full citation and rejection rationale
Notable Details
The comparison demonstrates that while RFC 0033 uses block-diagonal decomposition (like RotorQuant), the critical difference is block size and internal structure: B=256 with 3-round SORF provides substantially more mixing than RotorQuant's 3-4 dimensional groups. The new experimental plan directly addresses whether B=256 is large enough to avoid meaningful decorrelation loss through empirical measurement on real embeddings.
https://claude.ai/code/session_016qKqZ579LA83p7ThoAdqut