Repository navigation
test(e2e): let a step redact its output with its own patterns - #912
Merged
Merged
Conversation
Some steps remove several inputs at once, and vt reports whichever mismatch its parallel validation finds first, so the step's "cache miss" line changes from run to run. A new `redact` step key maps regexes to replacements; the harness applies them in key order to that step's output after the global redactions, and an invalid regex fails when the fixtures load. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fspy benchmarklinuxmacoswindows |
wan9chi
force-pushed
the
test/e2e-step-redact
branch
from
October 30, 2026 03:19
aeaa34c to
5ef290d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Later PRs in this stack test clean checkouts, which remove several inputs at once. vt reports whichever mismatch its parallel validation finds first, so the step's
cache miss: …line changes from run to run. Making vt compute every mismatch only to stabilize tests isn't worth it, so a step needs its own redaction.Changes
A table step takes
redact, a map from regex to replacement, applied in key order to that step's output after the global redactions. An invalid regex fails when the fixtures load.step_redactshows that a step's patterns touch only its own output.Part of a stack that lets automatic tracking cache tasks which read their own outputs and list the folders holding them, so they also hit on a clean checkout.
🤖 Generated with Claude Code