Skip to content

fix(cli): check npm workspaces for recursive outdated - #3240

Open
jong-kyung wants to merge 5 commits into
voidzero-dev:mainfrom
jong-kyung:fix/npm-outdated-recursive-workspaces
Open

jong-kyung wants to merge 5 commits into
voidzero-dev:mainfrom
jong-kyung:fix/npm-outdated-recursive-workspaces

Conversation

@jong-kyung

Copy link
Copy Markdown
Collaborator

Summary

Fix vp outdated -r to check npm workspaces instead of including transitive dependencies.

  • Use npm's --workspaces option instead of --all, which expands the dependency depth rather than selecting workspaces.
  • Require npm 7.14.0 or later, where outdated gained workspace support.

Reference

Map recursive outdated to --workspaces instead of --all, which includes
transitive dependencies. Require npm 7.14.0, where outdated gained
workspace support, and update resolver tests and CLI snapshots.
@jong-kyung jong-kyung self-assigned this Oct 26, 2026
@jong-kyung
jong-kyung requested a review from fengmk2 October 26, 2026 07:09
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-26T07:10:40.806958Z
We couldn’t complete this review. Comment @codex review to try again.
90dea79 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Comment thread crates/vp_pm_cli/src/resolution/commands/outdated.rs Outdated
Omit --workspaces when the workspace root is requested because npm's
workspace filter drops root dependencies even with --include-workspace-root.
Keep the default direct-dependency traversal and cover root-inclusive
recursion in the CLI snapshot.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants