Skip to content

DFM-4530: guard release-branch publish version line #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
franciscofabian wants to merge 1 commit into
base: main
Choose a base branch
from
Open

DFM-4530: guard release-branch publish version line #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,36 @@ jobs:
tool: twine

publish-package:
parameters:
assert-release-version:
description: >
On release-vN.M branches, fail if pyproject.toml's MAJOR.MINOR does not
match the branch line. Guards the timestamp_version invariant so a stray
version bump merged into a hotfix branch cannot publish out-of-line
artifacts (e.g. a 2.1.x build from a release-v2.0 branch).
type: boolean
default: false
executor:
<<: *python_executor_small
steps:
- checkout
- when:
condition: << parameters.assert-release-version >>
steps:
- run:
name: Assert pyproject.toml version matches release branch
command: |
branch_mm="${CIRCLE_BRANCH#release-v}"
pkg_ver="$(python -c "import tomllib; print(tomllib.load(open('pyproject.toml','rb'))['project']['version'])")"
pkg_mm="$(echo "$pkg_ver" | cut -d. -f1,2)"
if [ "$pkg_mm" != "$branch_mm" ]; then
echo "ERROR: pyproject.toml version $pkg_ver (MAJOR.MINOR=$pkg_mm) does not match"
echo "release branch $CIRCLE_BRANCH (expected line $branch_mm)."
echo "release-vN.M branches must keep pyproject.toml on their own MAJOR.MINOR so"
echo "timestamp_version publishes N.M.TIMESTAMP. Revert the version bump or branch from main."
exit 1
fi
echo "OK: pyproject.toml $pkg_ver is on the $branch_mm line."
- codeartifact/init:
tool: pip
- export-uv-auth
Expand Down Expand Up @@ -138,6 +164,7 @@ workflows:
only: /^release-v\d+\.\d+$/
- publish-package:
name: publish-package-release
assert-release-version: true
context: [sdlc, codeartifact-dev]
requires: [approve-release-publish]
filters:
Expand Down
4 changes: 4 additions & 0 deletions RELEASE_NOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@
run behind the manual `approve-release-publish` gate, while `main`
continues to auto-publish on merge. See
`docs/sdlc/sdlc-cicd-guide-backend.md` §4b.
- `release-vN.M` branches must keep `pyproject.toml` on their own
`MAJOR.MINOR` so `timestamp_version` publishes `N.M.TIMESTAMP`. CI enforces
this — the `publish-package-release` job fails if the version line drifts
from the branch.

## Release 2.0.7
- Add configurable DuckDB memory limit via `DUCKDB_MEMORY_LIMIT` environment variable
Expand Down