Some macOS improvements in bootstrap launcher and test app for codesigning#20863
Merged
markcmiller86 merged 3 commits intodevelopfrom Mar 16, 2026
Merged
Some macOS improvements in bootstrap launcher and test app for codesigning#20863markcmiller86 merged 3 commits intodevelopfrom
markcmiller86 merged 3 commits intodevelopfrom
Conversation
markcmiller86
commented
Mar 14, 2026
Member
Author
There was a problem hiding this comment.
This is the compiled, Mach-O binary. I don't think we need to commit this. It is compiled by test_notarize.py from testdmgnot.c.
markcmiller86
commented
Mar 14, 2026
Member
Author
There was a problem hiding this comment.
This has changed because the app being used to test notarization has changed. However, if the codesigning process includes time-stamping information of any kind (which it almost certainly does), the sha256 hash on this file is almost always going to change when someone runs test_notarize.py. I think that is fine though.
biagas
approved these changes
Mar 16, 2026
cyrush
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I asked ChatGPT to evaluate the macOS launcher (thats the thing that gets executed in response to double clicking the VisIt icon on the mac). It is what turns around and starts the normal VisIt startup scripts. It is also the critical macOS "thing" that macOS security system uses to manage permissions given by the user, etc. ChatGPT found a number of issues with my original, bare-bones coding of this bootstrap and then provided an improved version which I ran and tested a few different ways.
The test app for testing codesigning and notarization suffered some similar issues. In particular, it was NOT a Mach-O binary and was instead a python script. That doesn't really suffice for testing all the macOS codesigning stuff. So, I've fixed that too by making it a bona fide, clang-compiled, Mach-O binary which also puts up a dialog box when run via double-click.
Type of change
[ ] New feature[ ] Documentation update[ ] OtherHow Has This Been Tested?
Reminders:
Checklist:
[ ] I have updated the release notes.[ ] I have added tests that prove my fix is effective or that my feature works.[ ] I have confirmed new and existing unit tests pass locally with my changes.[ ] I have added new baselines for any new tests to the repo.[ ] I have NOT made any changes to protocol or public interfaces in an RC branch.