Conversation
With new CFITSIO libraries are named: libcfitsio.so -> libcfitsio.so.10 libcfitsio.so.10 -> libcfitsio.so.4.6.3 libcfitsio.so.4.6.3 Current logic finds and installs: libcfitsio.so -> libcfitsio.so.10 libcfitsio.so.4.6.3 Missing: libcfistio.10
cyrush
approved these changes
Mar 16, 2026
Member
cyrush
left a comment
There was a problem hiding this comment.
This looks good to me.
The old logic is a little confusing b/c this is a shared lib section, executed inside of:
if(${isSHAREDLIBRARY} STREQUAL "YES")
However there is logic there that as a lib.a version to the list.
Glob might also pick up static libs, but that may already be the behavior we have.
Contributor
Author
It is, due to this old line: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With new CFITSIO libraries are named:
libcfitsio.so -> libcfitsio.so.10
libcfitsio.so.10 -> libcfitsio.so.4.6.3
libcfitsio.so.4.6.3
Current logic finds and installs:
libcfitsio.so -> libcfitsio.so.10
libcfitsio.so.4.6.3
Missing: libcfistio.so.10
Logic was modified to use ( showing pseudocode):
file(GLOB allNAMES ' library-name-without-extensions.*')
Seems to work correctly on LINUX.
Thoughts on suitablity on MAC?
Type of change
[ ] New feature[ ] Documentation update[ ] OtherHow Has This Been Tested?
Tested on Linux, comilation, installation, and running plugin vs install against most plugins (more changes coming that make this work).
Checklist:
[ ] I have updated the release notes.[ ] I have made corresponding changes to the documentation.[ ] I have added debugging support to my changes.[ ] I have added tests that prove my fix is effective or that my feature works.[ ] I have added new baselines for any new tests to the repo.[ ] I have NOT made any changes to [protocol or public interfaces][3] in an RC branch.