Skip to content

Modify how tp library extensions (.so, .so.10, etc) are found for installation of the libraries.#20861

Merged
biagas merged 4 commits intodevelopfrom
bugfix/biagas/fix_finding_library_extensions
Mar 17, 2026
Merged

Modify how tp library extensions (.so, .so.10, etc) are found for installation of the libraries.#20861
biagas merged 4 commits intodevelopfrom
bugfix/biagas/fix_finding_library_extensions

Conversation

@biagas
Copy link
Copy Markdown
Contributor

@biagas biagas commented Mar 12, 2026

With new CFITSIO libraries are named:
libcfitsio.so -> libcfitsio.so.10
libcfitsio.so.10 -> libcfitsio.so.4.6.3
libcfitsio.so.4.6.3

Current logic finds and installs:
libcfitsio.so -> libcfitsio.so.10
libcfitsio.so.4.6.3

Missing: libcfistio.so.10

Logic was modified to use ( showing pseudocode):
file(GLOB allNAMES ' library-name-without-extensions.*')

Seems to work correctly on LINUX.
Thoughts on suitablity on MAC?

Type of change

  • Bug fix
  • [ ] New feature
  • [ ] Documentation update
  • [ ] Other

How Has This Been Tested?

Tested on Linux, comilation, installation, and running plugin vs install against most plugins (more changes coming that make this work).

Checklist:

  • I have commented my code where applicable.
  • [ ] I have updated the release notes.
  • [ ] I have made corresponding changes to the documentation.
  • [ ] I have added debugging support to my changes.
  • [ ] I have added tests that prove my fix is effective or that my feature works.
  • I have confirmed new and existing unit tests pass locally with my changes.~~
  • [ ] I have added new baselines for any new tests to the repo.
  • [ ] I have NOT made any changes to [protocol or public interfaces][3] in an RC branch.

With new CFITSIO libraries are named:
  libcfitsio.so -> libcfitsio.so.10
  libcfitsio.so.10 -> libcfitsio.so.4.6.3
  libcfitsio.so.4.6.3
Current logic finds and installs:
  libcfitsio.so -> libcfitsio.so.10
  libcfitsio.so.4.6.3
Missing:  libcfistio.10
@biagas biagas requested review from cyrush and markcmiller86 March 12, 2026 17:21
Copy link
Copy Markdown
Member

@cyrush cyrush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

The old logic is a little confusing b/c this is a shared lib section, executed inside of:

if(${isSHAREDLIBRARY} STREQUAL "YES")

However there is logic there that as a lib.a version to the list.

Glob might also pick up static libs, but that may already be the behavior we have.

@biagas
Copy link
Copy Markdown
Contributor Author

biagas commented Mar 16, 2026

Glob might also pick up static libs, but that may already be the behavior we have.

It is, due to this old line:
set(allNAMES ${allNAMES} "${curNAME}.a")

@biagas biagas merged commit 18c7eff into develop Mar 17, 2026
4 checks passed
@biagas biagas deleted the bugfix/biagas/fix_finding_library_extensions branch March 17, 2026 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants