Remove warnings from some of the visit_vtk/full classes.#20770
Draft
Remove warnings from some of the visit_vtk/full classes.#20770
Conversation
Convert vtkIdType members to size_t, to remove warnings related to using vtkIdType as an array index, and reduce the number of static_cast's to size_t that would need to be used to remove the warnings. Use "" for local header inclusion, <> for TP or outside current library. Can help reduce warnings to local code base and reduce warnings from TP headers (with the right compiler options). Replace use of 'NULL' with 'nullptr'. Add copy constructor and assignment operators designated as `delete` where necessary to remove warnings related to deleted implicitly defined methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This was part of a larger warning reduction branch, but when it came to xxxFromVolume classes, I noticed that a large number of static_casts from vtkIdType to size_t would be needed to remove warnings related to using vtkIdType as an array index.
This branch instead changes the use of vtkIdType to size_t to reduce that need.
I also added the classes that utilize xxxFromVolume to the warnings reduction.
Things done:
Convert vtkIdType members to size_t, to remove warnings related to using vtkIdType as an array index, and reduce the number of static_cast's to size_t that would need to be used to remove the warnings.
Use "" for local header inclusion, <> for TP or outside current library.
Can help reduce warnings to local code base and reduce warnings from TP headers (with the right compiler options).
Replace use of 'NULL' with 'nullptr'.
Add copy constructor and assignment operators designated as
deletewhere necessary to remove warnings related to deleted implicitly defined methods.Changed unimplemented copy constructor and assignment operators to be declared as deleted.
Modifiied vtkVisItClipper considerably, since the need for the 'Bridge' classes are no longer needed with new versions of VTK and improved API for accessing cells and points information.
remove vtkVisItSplitter as it is no longer used
Type of change
[ ] Bug fix[ ] New feature[ ] Documentation updateHow Has This Been Tested?
Compiled with all warnings turned on, Linux/Windows with no more warnings for the changed classes.
Checklist: