[issue-95] ci: drop the codex-review-gate, re-verify main weekly - #98
Merged
Conversation
The gate never worked here: 89 failing runs, all with zero jobs, because `on:` declared pull_request_review_thread, a webhook event Actions does not accept as a trigger. It is also a hand-rolled reimplementation of a platform feature. One GraphQL query plus a jq filter, four copies across the ecosystem, and a confessed lag its own header describes: resolving a thread emits no event Actions can see, so it clears on the next push rather than on resolution. `required_conversation_resolution` in branch protection does the same job with no runner, no query to maintain, and no lag, and it refuses outdated threads too, which this gate deliberately ignored on the assumption that Codex re-posts if the issue survives a rebase. That assumption was never guaranteed. So the control moves to branch protection and the workflow goes. This converges with vinicq/falsegreen, which deleted the same file in 65482f0. Also adds a weekly schedule to ci.yml: running only on push to main means a floating tool can break main while the badge stays green, which is exactly what ruff 0.16 just did here. Refs #95
vinicq
force-pushed
the
ci/delete-gate-and-cron
branch
from
August 11, 2026 21:24
afbd87d to
468bb6b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #95. Supersedes #96, which tried to repair the gate instead. The ruff fix that was in that branch is split into #97 and lands first, because
mainis red and that is not a CI-hygiene question.Why delete instead of repair
I opened #96 to repair this file, and repairing it was the wrong call. The gate is a hand-written reimplementation of a platform feature:
required_conversation_resolutionin branch protection does the same job with no runner, no GraphQL query to maintain, and no copies to keep in sync across four repos.required_conversation_resolutionrequires resolving all of them.The alternative was never compared against, because nobody had turned it on. The gate existed by omission rather than by choice.
What was actually broken
89 failing runs, every one with zero jobs: GitHub refusing to validate the file, not a check that fails.
on:declaredpull_request_review_thread, a real webhook event that Actions does not accept as a trigger.And the origin is worth recording, because it is the sharpest lesson here. In
falsegreen-js, where the same file landed, the workflow ran green exactly once, on the PR head that introduced it (5a3eed8), which declared only the three valid triggers.pull_request_review_threadwas added between that head and the squash to main (6c4b84d). The edit that killed the workflow was merged having never run. A gate that had never been exercised in its shipped form guarded nothing from day one.Independent confirmation, and a one-liner worth keeping:
A workflow whose
nameequals itspathis one GitHub never parsed. It flagged this repo andfalsegreen-js, and stayed silent for the repos where the file is absent or fixed.Ecosystem convergence
falsegreen65482f0)falsegreen-skillfalsegreen-jsrobotframework-falsegreenOne mechanism across four repos instead of two.
The weekly schedule stays
Running only on push to main means a floating tool can break main while the badge stays green. ruff 0.16 just did exactly that here.
scheduleplusworkflow_dispatchcaps that window at 7 days, and it covers more than ruff: runner image changes, any floating dependency.Follow-up, not in this PR
mainhere has no branch protection at all, sorequired_conversation_resolutionhas nothing to attach to yet. Enabling it is the other half of this change and lands as a repo settings change, not a commit.Rollback
git revertrestores the workflow. The repaired version is preserved on thefix/gate-trigger-and-cronbranch, which stays for now rather than being deleted with the PR, so the fix is recoverable if the deletion turns out to be wrong.