new feature: usertag @user inclusion, close #592 - #609
Open
vincent-peugnet wants to merge 2 commits into
Open
Conversation
vincent-peugnet
force-pushed
the
usertag
branch
from
April 15, 2026 10:32
fa36161 to
b11c1d0
Compare
n-peugnet
reviewed
Apr 15, 2026
| { | ||
| $rend = $this; | ||
| $id = Model::ID_REGEX; | ||
| $regex = "#(?<=^|\s)@($id)#"; |
Collaborator
There was a problem hiding this comment.
Pour le regex, j'aurais plutôt utilisé \B (ou bien \b, je les confonds toujours) pour le début, et la fin, genre #\B@($id)\b# (ou l'inverse).
Voir cet example
Owner
Author
There was a problem hiding this comment.
Yes ! figures toi que j'avais testé !
Mais ça accepte les cas comme:
!@test
Donc c'est plus souple.
Je m'étais dis que c'était mieux d'être strict, mais peut être que c'est trop strict. 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.