fix(player): add null safety when accessing srcObj.src and srcObj.type#9193
Open
xxiaoxiong wants to merge 1 commit into
Open
fix(player): add null safety when accessing srcObj.src and srcObj.type#9193xxiaoxiong wants to merge 1 commit into
xxiaoxiong wants to merge 1 commit into
Conversation
Fixes videojs#9185 When srcObj is a non-string object, updateSourceCaches_() accesses srcObj.src and srcObj.type without checking if these properties exist. If srcObj is null, {}, or an object with different keys, src and type will be undefined, leading to silent failures. Add optional chaining and nullish coalescing for safer access.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9185
Description
When
srcObjis a non-string object inupdateSourceCaches_(), the code accessessrcObj.srcandsrcObj.typewithout checking if these properties exist. IfsrcObjisnull,{}, or an object with different keys,srcandtypewill beundefined, leading to silent failures.Changes
src/js/player.js: Add optional chaining (?.) and nullish coalescing (??) for safer access tosrcObj.srcandsrcObj.type.