fix(player): fix operator precedence confusion in fullscreen checks#9192
Open
xxiaoxiong wants to merge 1 commit into
Open
fix(player): fix operator precedence confusion in fullscreen checks#9192xxiaoxiong wants to merge 1 commit into
xxiaoxiong wants to merge 1 commit into
Conversation
Fixes videojs#9182 Replace with to avoid operator precedence confusion. The operator has higher precedence than , so the original expression was parsed as , which works for booleans but is error-prone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9182
Description
Replace
!this.options_.preferFullWindow === truewiththis.options_.preferFullWindow !== truein two locations (requestFullscreenHelper_andexitFullscreenHelper_) to fix operator precedence confusion.The
!operator has higher precedence than===, so the original expression was parsed as(!this.options_.preferFullWindow) === true, which produces the same result for boolean values but is confusing and error-prone.Changes
src/js/player.js: Lines 3038, 3096