Do not lower measured bandwidth with Network Information API#1605
Open
PascalThuet wants to merge 1 commit into
Open
Do not lower measured bandwidth with Network Information API#1605PascalThuet wants to merge 1 commit into
PascalThuet wants to merge 1 commit into
Conversation
07c130d to
a7eaf35
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1604.
When
useNetworkInformationApiis enabled, VHS currently usesnavigator.connection.downlinkas the publicbandwidthvalue whenever Network Information API data is present, except for the existing>= 10 Mbpsspecial case. That can let a lower generic browser-level estimate override a higher player-specific bandwidth estimate after VHS has downloaded media segments.This change keeps the Network Information API behavior before media segment stats are available, and still allows it to raise the estimate afterward. Once the media segment loader has a player-specific estimate, however, Network Information API no longer lowers that value.
Specific Changes proposed
useNetworkInformationApiREADME entry to describe the post-segment-stats behavior.Requirements Checklist
Validation:
npm run lintCI_TEST_TYPE=unit npm run build-testCI_TEST_TYPE=unit npx karma start scripts/karma.conf.js --single-run --browsers ChromeHeadless