Remove the google maps 3D #381
Merged
+0
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't work any more as a basemap.
Something like this would work
this.map = new Map({
basemap: this.basemaps.Satellite,
ground: { layers: [this.elevationLayer] },
layers: [google3DTilesLayer]
});
Disabling for now
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRemoves the now-broken Google 3D basemap configuration from the 3D map component, leaving other basemaps intact. Class diagram for Map3dElement basemap configuration changesclassDiagram
class Map3dElement {
- airspace Airspace3dElement
- basemaps Record_string_BasemapOrStringOrNull_
- createBasemaps()
}
class Basemap {
+baseLayers IntegratedMesh3DTilesLayer[*]
+referenceLayers Layer[*]
+title string
+id string
}
class IntegratedMesh3DTilesLayer {
+url string
+title string
+customParameters Record_string_string_
}
Map3dElement --> Basemap : uses
Basemap --> IntegratedMesh3DTilesLayer : baseLayers
%% Before change
class BasemapsBefore {
+Satellite BasemapOrStringOrNull
+Google BasemapOrStringOrNull
+OpenTopoMap BasemapOrStringOrNull
+IGN_France BasemapOrStringOrNull
+Topo BasemapOrStringOrNull
}
%% After change
class BasemapsAfter {
+Satellite BasemapOrStringOrNull
+OpenTopoMap BasemapOrStringOrNull
+IGN_France BasemapOrStringOrNull
+Topo BasemapOrStringOrNull
}
Map3dElement --> BasemapsBefore : basemaps (removed)
Map3dElement --> BasemapsAfter : basemaps (new)
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
WalkthroughThe change removes Google basemap support from a 3D map component by eliminating the basemap option from configuration, its construction logic, and associated imports for IntegratedMesh3DTilesLayer and API key retrieval utilities. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Repository UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Now that the
Googlebasemap is removed from thebasemapsmap, double-check any UI or configuration logic that referencedbasemaps.Google(e.g., basemap selectors or defaults) so they don’t try to use a non-existent key. - If
IntegratedMesh3DTilesLayeris no longer used anywhere after this removal, consider deleting its import and any related configuration to avoid carrying unused dependencies.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Now that the `Google` basemap is removed from the `basemaps` map, double-check any UI or configuration logic that referenced `basemaps.Google` (e.g., basemap selectors or defaults) so they don’t try to use a non-existent key.
- If `IntegratedMesh3DTilesLayer` is no longer used anywhere after this removal, consider deleting its import and any related configuration to avoid carrying unused dependencies.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Deploying flyxc with
|
| Latest commit: |
72398fd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://21f22284.flyxc.pages.dev |
| Branch Preview URL: | https://vicb-gmap-3d.flyxc.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't work any more as a basemap.
Something like this would work
Disabling for now
Summary by Sourcery
Bug Fixes:
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.