Conversation
vharseko
commented
Jun 25, 2026
vharseko
commented
Owner
- CVE-2026-55760 handlebars.java FileTemplateLoader Path Traversal OpenIdentityPlatform/OpenIDM#194
vharseko
added a commit
that referenced
this pull request
Jul 16, 2026
…deQL java/implicit-cast-in-compound-assignment) (OpenIdentityPlatform#206) skip(long n) reduced n with Math.min(n, data.length - position) and then did `position += n`, where position is an int. That compound assignment implicitly narrows the long back to int. There is no actual overflow: Math.min bounds the value to data.length - position, and position is always in [0, data.length], so the result fits in an int and position + skipped never exceeds data.length. Make the narrowing explicit by computing the skipped count as an int (the (int) cast is lossless for the reasons above), doing the compound assignment in pure int arithmetic, and widening back to long on return. Behaviour is unchanged. Fixes code-scanning alert #1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.