BugFix - Table name/Model name unintentional corruption#1362
Merged
mail4umar merged 2 commits intovertica:masterfrom Mar 11, 2026
Merged
BugFix - Table name/Model name unintentional corruption#1362mail4umar merged 2 commits intovertica:masterfrom
mail4umar merged 2 commits intovertica:masterfrom
Conversation
Collaborator
|
overall looks good to me. |
vikash018
approved these changes
Mar 11, 2026
vikash018
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported here: #1339
Added the
replace_outside_quoteshelper function that skips over single-quoted string literals and double-quoted identifiers when applying replacements.Modified
indent_vpy_sqlto usereplace_outside_quotesinstead of the naive chain ofreplace()calls, so SQL keywords embedded inside quoted identifiers (e.g., "TEST_SELECTION_BUG_5") are never corrupted.closes: #1363