Security Patch - Resolving path manipulation vulnerability#1361
Merged
mail4umar merged 1 commit intovertica:masterfrom Feb 3, 2026
Merged
Security Patch - Resolving path manipulation vulnerability#1361mail4umar merged 1 commit intovertica:masterfrom
mail4umar merged 1 commit intovertica:masterfrom
Conversation
Ensuring the path from the user is checked. - resolving path to absolute - ensuring path exists - checking if its an actual file
roypaulin
reviewed
Feb 2, 2026
Comment on lines
+185
to
+192
| if not path: | ||
| raise ValueError("path must be provided when method='copy'") | ||
| # Validate path to prevent path traversal attacks | ||
| file_path = Path(path).resolve() | ||
| # Ensure the resolved path exists and is a file | ||
| if not file_path.is_file(): | ||
| raise ValueError(f"File not found or is not a regular file: {path}") | ||
| with open(file_path, "r", encoding="utf-8") as f: |
Collaborator
There was a problem hiding this comment.
Should the file be in an allowed base directory? If we you should add a check for that.
Collaborator
Author
There was a problem hiding this comment.
I think the file can be anywhere. its the user's own system. no need to restrict the user.
roypaulin
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensuring the path from the user is checked.