fix: count CommonPrefixes in POSIX ListObjectsV2 responses - #2358
Merged
Merged
Conversation
Collaborator
|
This won't automatically run in continuous integration without approval. A member of the Versity organization must allow it. |
benmcclelland
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The POSIX backend calculated
ListObjectsV2.KeyCountusing only thenumber of returned objects:
When a delimiter listing returned only CommonPrefixes, the response
contained KeyCount=0 even though prefixes were present. This caused
Docker Registry garbage collection to fail with:
Path not found: /docker/registry/v2/repositories
Solution
Calculate KeyCount using both returned objects and common prefixes:
This matches AWS S3 semantics and the existing Azure backend behavior.
Testing
AI Assistance
AI was used during the investigation and writing process to inspect the relevant code paths, identify the
KeyCountcalculation issue, and help prepare this pull request description. The final code change and testresults were reviewed manually.