Skip to content

Do not include initial attempt in step function maxRetries count #703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TooTallNate merged 3 commits into from
Dec 31, 2025
Merged

Do not include initial attempt in step function maxRetries count #703

TooTallNate merged 3 commits into from
Dec 31, 2025
+175 −26

Conversation

@TooTallNate
Copy link
Member

@TooTallNate TooTallNate commented Dec 29, 2025 •
edited
Loading

Closes #592.

Fixed how maxRetries is counted in step functions to exclude the initial attempt.

What changed?

  • Modified the step handler logic to correctly interpret maxRetries as the number of retry attempts after the initial attempt fails
  • Updated documentation to clarify that maxRetries = 5 means 6 total attempts (1 initial + 5 retries)
  • Added a callout in the docs explaining that maxRetries = 0 means the step runs once with no retries
  • Added an E2E test to verify that steps with maxRetries = 0 run once without retrying
  • Improved error messages to clearly distinguish between attempts and retries

Why make this change?

The previous implementation was counting the initial attempt as part of the retry count, which was confusing and inconsistent with common retry patterns. This change makes the behavior more intuitive - maxRetries now specifically refers to the number of retry attempts after the initial attempt fails, making the total number of attempts equal to maxRetries + 1.

@changeset-bot
Copy link

changeset-bot bot commented Dec 29, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 9103b39

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@workflow/core Patch
@workflow/web Patch
@workflow/utils Patch
@workflow/builders Patch
@workflow/cli Patch
@workflow/next Patch
@workflow/nitro Patch
@workflow/web-shared Patch
workflow Patch
@workflow/errors Patch
@workflow/world-local Patch
@workflow/astro Patch
@workflow/sveltekit Patch
@workflow/world-testing Patch
@workflow/nuxt Patch
@workflow/ai Patch
@workflow/world-postgres Patch
@workflow/world-vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Contributor

vercel bot commented Dec 29, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
example-nextjs-workflow-turbopack Ready Ready Preview, Comment Dec 30, 2025 6:12pm
example-nextjs-workflow-webpack Ready Ready Preview, Comment Dec 30, 2025 6:12pm
example-workflow Ready Ready Preview, Comment Dec 30, 2025 6:12pm
workbench-astro-workflow Ready Ready Preview, Comment Dec 30, 2025 6:12pm
workbench-express-workflow Ready Ready Preview, Comment Dec 30, 2025 6:12pm
workbench-fastify-workflow Ready Ready Preview, Comment Dec 30, 2025 6:12pm
workbench-hono-workflow Ready Ready Preview, Comment Dec 30, 2025 6:12pm
workbench-nitro-workflow Ready Ready Preview, Comment Dec 30, 2025 6:12pm
workbench-nuxt-workflow Ready Ready Preview, Comment Dec 30, 2025 6:12pm
workbench-sveltekit-workflow Ready Ready Preview, Comment Dec 30, 2025 6:12pm
workbench-vite-workflow Ready Ready Preview, Comment Dec 30, 2025 6:12pm
workflow-docs Ready Ready Preview, Comment Dec 30, 2025 6:12pm

@github-actions
Copy link
Contributor

github-actions bot commented Dec 29, 2025 •
edited
Loading

📊 Benchmark Results

📈 Comparing against baseline from main branch. Green 🟢 = faster, Red 🔺 = slower.

workflow with no steps

💻 Local Development

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
💻 Local 🥇 Next.js (Turbopack) 0.037s (-5.8% 🟢) 1.015s (~) 0.978s 10 1.00x
🌐 Redis Next.js (Turbopack) 0.038s (-6.2% 🟢) 1.016s (~) 0.978s 10 1.02x
🌐 Starter Next.js (Turbopack) 0.039s (+8.1% 🔺) 1.014s (~) 0.976s 10 1.04x
💻 Local Nitro 0.041s (+38.9% 🔺) 1.006s (~) 0.965s 10 1.12x
💻 Local Express 0.043s (-2.0%) 1.007s (~) 0.963s 10 1.17x
🌐 Turso Next.js (Turbopack) 0.082s (-19.8% 🟢) 1.014s (~) 0.932s 10 2.22x
🌐 MongoDB Next.js (Turbopack) 0.086s (+10.3% 🔺) 1.015s (~) 0.928s 10 2.33x
🐘 Postgres Next.js (Turbopack) 0.262s (+0.9%) 1.022s (~) 0.760s 10 7.05x
🐘 Postgres Express 0.283s (-24.9% 🟢) 1.026s (+1.2%) 0.742s 10 7.63x
🐘 Postgres Nitro 0.296s (+6.4% 🔺) 1.016s (~) 0.720s 10 7.98x

▲ Production (Vercel)

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
▲ Vercel 🥇 Express 0.578s (~) 1.665s (+3.4%) 1.087s 10 1.00x
▲ Vercel Nitro 0.641s (-36.9% 🟢) 1.696s (-11.3% 🟢) 1.055s 10 1.11x
▲ Vercel Next.js (Turbopack) 0.748s (+41.7% 🔺) 1.746s (+24.8% 🔺) 0.998s 10 1.29x

🔍 Observability: Express | Nitro | Next.js (Turbopack)

workflow with 1 step

💻 Local Development

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
🌐 Starter 🥇 Next.js (Turbopack) 1.082s (-0.5%) 2.010s (~) 0.928s 10 1.00x
💻 Local Next.js (Turbopack) 1.096s (~) 2.012s (~) 0.915s 10 1.01x
🌐 Redis Next.js (Turbopack) 1.097s (~) 2.011s (~) 0.914s 10 1.01x
💻 Local Nitro 1.112s (+3.4%) 2.006s (~) 0.894s 10 1.03x
💻 Local Express 1.112s (~) 2.007s (~) 0.895s 10 1.03x
🌐 Turso Next.js (Turbopack) 1.294s (~) 2.013s (~) 0.719s 10 1.20x
🌐 MongoDB Next.js (Turbopack) 1.304s (+1.1%) 2.014s (~) 0.710s 10 1.20x
🐘 Postgres Next.js (Turbopack) 1.872s (-21.3% 🟢) 2.017s (-33.1% 🟢) 0.144s 10 1.73x
🐘 Postgres Nitro 2.130s (~) 3.014s (~) 0.885s 10 1.97x
🐘 Postgres Express 2.265s (+1.2%) 3.023s (~) 0.759s 10 2.09x

▲ Production (Vercel)

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
▲ Vercel 🥇 Nitro 2.849s (+2.4%) 3.761s (+5.0%) 0.912s 10 1.00x
▲ Vercel Express 2.946s (+10.3% 🔺) 3.866s (+5.6% 🔺) 0.920s 10 1.03x
▲ Vercel Next.js (Turbopack) 3.006s (+6.6% 🔺) 3.827s (+6.1% 🔺) 0.822s 10 1.06x

🔍 Observability: Nitro | Express | Next.js (Turbopack)

workflow with 10 sequential steps

💻 Local Development

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
🌐 Starter 🥇 Next.js (Turbopack) 10.581s (~) 11.011s (~) 0.430s 5 1.00x
💻 Local Next.js (Turbopack) 10.649s (~) 11.015s (~) 0.366s 5 1.01x
🌐 Redis Next.js (Turbopack) 10.667s (-0.5%) 11.013s (~) 0.346s 5 1.01x
💻 Local Express 10.785s (~) 11.013s (~) 0.228s 5 1.02x
💻 Local Nitro 10.787s (+2.6%) 11.014s (~) 0.227s 5 1.02x
🌐 Turso Next.js (Turbopack) 12.182s (~) 13.027s (~) 0.845s 5 1.15x
🌐 MongoDB Next.js (Turbopack) 12.257s (~) 13.027s (~) 0.770s 5 1.16x
🐘 Postgres Next.js (Turbopack) 15.233s (-4.3%) 16.035s (-3.6%) 0.802s 5 1.44x
🐘 Postgres Express 20.408s (+1.5%) 21.038s (~) 0.631s 5 1.93x
🐘 Postgres Nitro 20.479s (~) 21.031s (~) 0.552s 5 1.94x

▲ Production (Vercel)

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
▲ Vercel 🥇 Express 26.918s (+22.9% 🔺) 27.629s (+21.4% 🔺) 0.711s 5 1.00x
▲ Vercel Nitro 27.193s (+26.5% 🔺) 27.903s (+25.0% 🔺) 0.710s 5 1.01x
▲ Vercel Next.js (Turbopack) 27.900s (+24.8% 🔺) 28.635s (+25.0% 🔺) 0.735s 5 1.04x

🔍 Observability: Express | Nitro | Next.js (Turbopack)

Promise.all with 10 concurrent steps

💻 Local Development

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
🌐 Redis 🥇 Next.js (Turbopack) 1.347s (-0.7%) 2.010s (~) 0.663s 15 1.00x
🌐 Starter Next.js (Turbopack) 1.350s (+1.0%) 2.007s (~) 0.657s 15 1.00x
💻 Local Next.js (Turbopack) 1.382s (-0.9%) 2.013s (~) 0.631s 15 1.03x
💻 Local Nitro 1.408s (+5.6% 🔺) 2.006s (~) 0.597s 15 1.05x
💻 Local Express 1.423s (+1.3%) 2.006s (~) 0.583s 15 1.06x
🐘 Postgres Next.js (Turbopack) 2.067s (+6.2% 🔺) 2.227s (+3.3%) 0.161s 14 1.53x
🌐 MongoDB Next.js (Turbopack) 2.138s (~) 3.015s (~) 0.877s 10 1.59x
🌐 Turso Next.js (Turbopack) 2.207s (~) 3.012s (~) 0.805s 10 1.64x
🐘 Postgres Nitro 2.399s (-1.2%) 3.011s (~) 0.612s 10 1.78x
🐘 Postgres Express 2.430s (-3.0%) 3.015s (~) 0.585s 10 1.80x

▲ Production (Vercel)

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
▲ Vercel 🥇 Express 3.331s (+22.3% 🔺) 4.270s (+15.6% 🔺) 0.939s 8 1.00x
▲ Vercel Nitro 3.500s (+23.0% 🔺) 4.314s (+19.9% 🔺) 0.813s 7 1.05x
▲ Vercel Next.js (Turbopack) 4.836s (+69.2% 🔺) 5.698s (+54.8% 🔺) 0.862s 6 1.45x

🔍 Observability: Express | Nitro | Next.js (Turbopack)

Promise.all with 25 concurrent steps

💻 Local Development

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
💻 Local 🥇 Next.js (Turbopack) 2.117s (-2.4%) 3.047s (+1.1%) 0.930s 10 1.00x
💻 Local Nitro 2.185s (+10.7% 🔺) 3.131s (+45.4% 🔺) 0.946s 10 1.03x
💻 Local Express 2.194s (-1.8%) 3.161s (~) 0.968s 10 1.04x
🌐 Starter Next.js (Turbopack) 2.440s (~) 3.009s (~) 0.568s 10 1.15x
🌐 Redis Next.js (Turbopack) 2.486s (~) 3.010s (~) 0.524s 10 1.17x
🐘 Postgres Next.js (Turbopack) 2.688s (+2.8%) 3.013s (~) 0.325s 10 1.27x
🐘 Postgres Express 2.860s (+5.4% 🔺) 3.361s (+11.6% 🔺) 0.501s 9 1.35x
🐘 Postgres Nitro 3.111s (+7.1% 🔺) 3.769s (+17.1% 🔺) 0.658s 8 1.47x
🌐 MongoDB Next.js (Turbopack) 4.643s (-0.7%) 5.180s (~) 0.537s 6 2.19x
🌐 Turso Next.js (Turbopack) 4.713s (+1.5%) 5.184s (~) 0.471s 6 2.23x

▲ Production (Vercel)

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
▲ Vercel 🥇 Express 4.615s (+26.7% 🔺) 5.661s (+29.9% 🔺) 1.046s 6 1.00x
▲ Vercel Next.js (Turbopack) 5.257s (+17.3% 🔺) 6.066s (+23.0% 🔺) 0.809s 5 1.14x
▲ Vercel Nitro 5.463s (+41.2% 🔺) 6.367s (+39.4% 🔺) 0.904s 5 1.18x

🔍 Observability: Express | Next.js (Turbopack) | Nitro

Promise.race with 10 concurrent steps

💻 Local Development

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
🌐 Redis 🥇 Next.js (Turbopack) 1.337s (-1.7%) 2.010s (~) 0.672s 15 1.00x
🌐 Starter Next.js (Turbopack) 1.349s (+0.9%) 2.008s (~) 0.658s 15 1.01x
💻 Local Next.js (Turbopack) 1.395s (-1.2%) 2.012s (~) 0.617s 15 1.04x
💻 Local Express 1.410s (~) 2.006s (~) 0.596s 15 1.05x
💻 Local Nitro 1.426s (+6.8% 🔺) 2.006s (~) 0.580s 15 1.07x
🐘 Postgres Next.js (Turbopack) 1.693s (-1.1%) 2.016s (~) 0.322s 15 1.27x
🐘 Postgres Express 1.773s (+5.1% 🔺) 2.010s (~) 0.237s 15 1.33x
🐘 Postgres Nitro 2.081s (+0.7%) 2.320s (-7.8% 🟢) 0.239s 13 1.56x
🌐 MongoDB Next.js (Turbopack) 2.154s (~) 3.013s (~) 0.859s 10 1.61x
🌐 Turso Next.js (Turbopack) 2.232s (~) 3.015s (~) 0.784s 10 1.67x

▲ Production (Vercel)

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
▲ Vercel 🥇 Next.js (Turbopack) 3.252s (+11.3% 🔺) 4.072s (+15.0% 🔺) 0.819s 8 1.00x
▲ Vercel Nitro 3.477s (+26.9% 🔺) 4.413s (+22.9% 🔺) 0.936s 7 1.07x
▲ Vercel Express 3.604s (+21.5% 🔺) 4.397s (+10.3% 🔺) 0.793s 7 1.11x

🔍 Observability: Next.js (Turbopack) | Nitro | Express

Promise.race with 25 concurrent steps

💻 Local Development

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
💻 Local 🥇 Express 2.214s (-1.1%) 3.160s (-0.6%) 0.946s 10 1.00x
💻 Local Nitro 2.303s (+15.9% 🔺) 3.232s (+45.2% 🔺) 0.929s 10 1.04x
💻 Local Next.js (Turbopack) 2.378s (+14.8% 🔺) 3.276s (+13.3% 🔺) 0.899s 10 1.07x
🌐 Redis Next.js (Turbopack) 2.471s (~) 3.035s (+0.8%) 0.564s 10 1.12x
🌐 Starter Next.js (Turbopack) 2.471s (-1.5%) 3.009s (~) 0.538s 10 1.12x
🐘 Postgres Express 2.585s (+0.7%) 3.031s (~) 0.446s 10 1.17x
🐘 Postgres Next.js (Turbopack) 2.675s (+3.8%) 3.122s (+3.5%) 0.447s 10 1.21x
🐘 Postgres Nitro 2.998s (+7.0% 🔺) 3.350s (+11.1% 🔺) 0.352s 9 1.35x
🌐 MongoDB Next.js (Turbopack) 4.668s (-1.2%) 5.182s (~) 0.514s 6 2.11x
🌐 Turso Next.js (Turbopack) 4.785s (+1.3%) 5.182s (~) 0.397s 6 2.16x

▲ Production (Vercel)

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
▲ Vercel 🥇 Express 3.698s (+19.4% 🔺) 4.538s (+24.9% 🔺) 0.840s 7 1.00x
▲ Vercel Nitro 3.716s (+10.2% 🔺) 4.434s (+8.8% 🔺) 0.718s 7 1.00x
▲ Vercel Next.js (Turbopack) 3.811s (+17.7% 🔺) 4.909s (+32.9% 🔺) 1.097s 7 1.03x

🔍 Observability: Express | Nitro | Next.js (Turbopack)

Stream Benchmarks (includes TTFB metrics)
workflow with stream

💻 Local Development

World Framework Workflow Time TTFB Slurp Wall Time Overhead Samples vs Fastest
🌐 Starter 🥇 Next.js (Turbopack) 0.125s (-5.4% 🟢) 1.004s (~) 0.000s (+Infinity% 🔺) 1.010s (~) 0.885s 10 1.00x
🌐 Redis Next.js (Turbopack) 0.142s (-11.0% 🟢) 1.004s (~) 0.000s (NaN%) 1.014s (~) 0.872s 10 1.13x
💻 Local Next.js (Turbopack) 0.148s (+3.6%) 1.004s (~) 0.017s (+1.2%) 1.029s (~) 0.881s 10 1.18x
💻 Local Express 0.176s (+0.8%) 0.993s (~) 0.017s (-1.2%) 1.024s (~) 0.848s 10 1.40x
💻 Local Nitro 0.176s (+65.0% 🔺) 0.992s (-0.7%) 0.014s (~) 1.020s (~) 0.844s 10 1.40x
🌐 Turso Next.js (Turbopack) 0.505s (+1.9%) 0.943s (-1.2%) 0.000s (-50.0% 🟢) 1.013s (~) 0.508s 10 4.03x
🌐 MongoDB Next.js (Turbopack) 0.511s (+7.4% 🔺) 0.939s (-3.7%) 0.000s (+100.0% 🔺) 1.014s (~) 0.502s 10 4.08x
🐘 Postgres Next.js (Turbopack) 1.183s (-4.6%) 1.865s (+3.2%) 0.000s (NaN%) 2.019s (~) 0.836s 10 9.43x
🐘 Postgres Express 2.215s (-9.3% 🟢) 2.830s (+8.8% 🔺) 0.000s (-100.0% 🟢) 3.015s (~) 0.801s 10 17.66x
🐘 Postgres Nitro 2.291s (-2.0%) 2.751s (+1.6%) 0.000s (~) 3.014s (~) 0.723s 10 18.27x

▲ Production (Vercel)

World Framework Workflow Time TTFB Slurp Wall Time Overhead Samples vs Fastest
▲ Vercel 🥇 Express 3.194s (+13.1% 🔺) 3.393s (+8.0% 🔺) 0.741s (+52.5% 🔺) 4.749s (+12.5% 🔺) 1.555s 10 1.00x
▲ Vercel Nitro 3.242s (+5.1% 🔺) 3.571s (+4.5%) 0.794s (+42.6% 🔺) 4.917s (+11.2% 🔺) 1.674s 10 1.02x
▲ Vercel Next.js (Turbopack) 3.462s (+18.3% 🔺) 4.165s (+24.8% 🔺) 1.437s (+186.2% 🔺) 6.202s (+45.2% 🔺) 2.740s 10 1.08x

🔍 Observability: Express | Nitro | Next.js (Turbopack)

Summary

Fastest Framework by World

Winner determined by most benchmark wins

World 🥇 Fastest Framework Wins
💻 Local Next.js (Turbopack) 7/8
🐘 Postgres Next.js (Turbopack) 7/8
▲ Vercel Express 6/8
Fastest World by Framework

Winner determined by most benchmark wins

Framework 🥇 Fastest World Wins
Express 💻 Local 8/8
Next.js (Turbopack) 💻 Local 3/8
Nitro 💻 Local 8/8
Column Definitions
  • Workflow Time: Runtime reported by workflow (completedAt - createdAt) - primary metric
  • TTFB: Time to First Byte - time from workflow start until first stream byte received (stream benchmarks only)
  • Slurp: Time from first byte to complete stream consumption (stream benchmarks only)
  • Wall Time: Total testbench time (trigger workflow + poll for result)
  • Overhead: Testbench overhead (Wall Time - Workflow Time)
  • Samples: Number of benchmark iterations run
  • vs Fastest: How much slower compared to the fastest configuration for this benchmark

Worlds:

  • 💻 Local: In-memory filesystem world (local development)
  • 🐘 Postgres: PostgreSQL database world (local development)
  • ▲ Vercel: Vercel production/preview deployment
  • 🌐 Starter: Community world (local development)
  • 🌐 Turso: Community world (local development)
  • 🌐 MongoDB: Community world (local development)
  • 🌐 Redis: Community world (local development)
  • 🌐 Jazz: Community world (local development)

📋 View full workflow run

@github-actions
Copy link
Contributor

github-actions bot commented Dec 29, 2025 •
edited
Loading

🧪 E2E Test Results

❌ Some tests failed

Summary

Passed Failed Skipped Total
❌ ▲ Vercel Production 289 8 11 308
✅ 💻 Local Development 272 0 8 280
✅ 📦 Local Production 272 0 8 280
✅ 🐘 Local Postgres 272 0 8 280
❌ 🪟 Windows 0 28 0 28
❌ 🌍 Community Worlds 113 11 0 124
Total 1218 47 35 1300

❌ Failed Tests

▲ Vercel Production (8 failed)

nextjs-turbopack (8 failed):

  • addTenWorkflow
  • addTenWorkflow
  • retryAttemptCounterWorkflow
  • crossFileErrorWorkflow - stack traces work across imported modules
  • hookCleanupTestWorkflow - hook token reuse after workflow completion
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars)
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step
🪟 Windows (28 failed)

nextjs-turbopack (28 failed):

  • addTenWorkflow
  • addTenWorkflow
  • should work with react rendering in step
  • promiseAllWorkflow
  • promiseRaceWorkflow
  • promiseAnyWorkflow
  • readableStreamWorkflow
  • hookWorkflow
  • webhookWorkflow
  • webhook route with invalid token
  • sleepingWorkflow
  • nullByteWorkflow
  • workflowAndStepMetadataWorkflow
  • outputStreamWorkflow
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions
  • fetchWorkflow
  • promiseRaceStressTestWorkflow
  • retryAttemptCounterWorkflow
  • retryableAndFatalErrorWorkflow
  • maxRetriesZeroWorkflow - maxRetries=0 runs once without retrying
  • stepDirectCallWorkflow - calling step functions directly outside workflow context
  • crossFileErrorWorkflow - stack traces work across imported modules
  • hookCleanupTestWorkflow - hook token reuse after workflow completion
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars)
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument
  • closureVariableWorkflow - nested step functions with closure variables
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step
  • health check endpoint - workflow and step endpoints respond to __health query parameter
🌍 Community Worlds (11 failed)

mongodb (1 failed):

  • webhookWorkflow

redis (1 failed):

  • webhookWorkflow

starter (8 failed):

  • addTenWorkflow
  • addTenWorkflow
  • retryAttemptCounterWorkflow
  • crossFileErrorWorkflow - stack traces work across imported modules
  • hookCleanupTestWorkflow - hook token reuse after workflow completion
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars)
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step

turso (1 failed):

  • webhookWorkflow

Details by Category

❌ ▲ Vercel Production
App Passed Failed Skipped
✅ astro 27 0 1
✅ example 27 0 1
✅ express 27 0 1
✅ fastify 27 0 1
✅ hono 27 0 1
❌ nextjs-turbopack 19 8 1
✅ nextjs-webpack 27 0 1
✅ nitro 27 0 1
✅ nuxt 27 0 1
✅ sveltekit 27 0 1
✅ vite 27 0 1
✅ 💻 Local Development
App Passed Failed Skipped
✅ astro-stable 27 0 1
✅ express-stable 27 0 1
✅ fastify-stable 27 0 1
✅ hono-stable 27 0 1
✅ nextjs-turbopack-stable 28 0 0
✅ nextjs-webpack-stable 28 0 0
✅ nitro-stable 27 0 1
✅ nuxt-stable 27 0 1
✅ sveltekit-stable 27 0 1
✅ vite-stable 27 0 1
✅ 📦 Local Production
App Passed Failed Skipped
✅ astro-stable 27 0 1
✅ express-stable 27 0 1
✅ fastify-stable 27 0 1
✅ hono-stable 27 0 1
✅ nextjs-turbopack-stable 28 0 0
✅ nextjs-webpack-stable 28 0 0
✅ nitro-stable 27 0 1
✅ nuxt-stable 27 0 1
✅ sveltekit-stable 27 0 1
✅ vite-stable 27 0 1
✅ 🐘 Local Postgres
App Passed Failed Skipped
✅ astro-stable 27 0 1
✅ express-stable 27 0 1
✅ fastify-stable 27 0 1
✅ hono-stable 27 0 1
✅ nextjs-turbopack-stable 28 0 0
✅ nextjs-webpack-stable 28 0 0
✅ nitro-stable 27 0 1
✅ nuxt-stable 27 0 1
✅ sveltekit-stable 27 0 1
✅ vite-stable 27 0 1
❌ 🪟 Windows
App Passed Failed Skipped
❌ nextjs-turbopack 0 28 0
❌ 🌍 Community Worlds
App Passed Failed Skipped
✅ mongodb-dev 3 0 0
❌ mongodb 27 1 0
✅ redis-dev 3 0 0
❌ redis 27 1 0
✅ starter-dev 3 0 0
❌ starter 20 8 0
✅ turso-dev 3 0 0
❌ turso 27 1 0

📋 View full workflow run

❌ Some E2E test jobs failed:

  • Vercel Prod: failure
  • Local Dev: success
  • Local Prod: success
  • Local Postgres: success
  • Windows: success

Check the workflow run for details.

@TooTallNate Graphite App
Copy link
Member Author

TooTallNate commented Dec 29, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@TooTallNate TooTallNate marked this pull request as ready for review December 29, 2025 18:22
Copilot AI review requested due to automatic review settings December 29, 2025 18:22
@TooTallNate TooTallNate force-pushed the 12-29-do_not_include_initial_attempt_in_step_function_maxretries_count branch from bce8846 to 9103b39 Compare December 30, 2025 18:10
@TooTallNate TooTallNate merged commit 9b1640d into main Dec 31, 2025
195 of 199 checks passed
@TooTallNate TooTallNate deleted the 12-29-do_not_include_initial_attempt_in_step_function_maxretries_count branch December 31, 2025 08:59
@vercel-release-bot vercel-release-bot mentioned this pull request Dec 31, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@VaguelySerious VaguelySerious VaguelySerious approved these changes

@pranaygp pranaygp Awaiting requested review from pranaygp

@Schniz Schniz Awaiting requested review from Schniz

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

maxRetries on a step includes first try, not just "re"-tries

3 participants

@TooTallNate @VaguelySerious