-
Notifications
You must be signed in to change notification settings - Fork 153
feat: openrouter provider #569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 0954abb The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@lawsonoates is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
VaguelySerious
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks goo to me, though we changed the package structure slightly since this PR was made. Could you:
- Merge main
- Ensure DCO passes (your latest commit should use the
-sflag in git) - Add a changeset (
npm changeset) as apatchfor the@workflow/aipackage
?
Then I'm happy to merge this PR
…provider Signed-off-by: lawsonoates <[email protected]>
Signed-off-by: lawsonoates <[email protected]>
|
should be good :) |
VaguelySerious
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! DCO doesn't seem to pass (see CI check), which is the only thing preventing me from merging this, sorry for the trouble
DCO Remediation Commit for lawsonoates <[email protected]> I, lawsonoates <[email protected]>, hereby add my Signed-off-by to this commit: 58c7051 Signed-off-by: lawsonoates <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The goal with @workflow/ai is to match the AI SDK in compat. Since openrouter is not a package under the @ai-sdk org, I don't think we should natively support it here
You can publish this package yourself though, or potentially ship it under the @openrouter org as @openrouter/ai-sdk-provider/workflow. Or you could also open up an issue on the AI sdk repo to bring native support there in the AI sdk
ofcourse, as noticed in this PR, there's also not reason this has to be a package explicitly and you can simply use openrouter directly in workflow using the pattern you've shown :)
|
That makes a lot of sense. At the heart of it I was trying to address the differences in using a provider from Perhaps #570 |
Added openrouter provider to ai package