Repository navigation
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
| "timers.clearTimeout": { argTypes: [F64], result: VOID }, | ||
| /** Timeout.close() — clearTimeout(this) that returns the handle for | ||
| * chaining. Node's legacy cancel; mock-aware like clearTimeout. */ | ||
| "timers.close": { argTypes: [F64], result: F64 }, |
Contributor
There was a problem hiding this comment.
The new timers.close, event.onceTarget and event.onceTargetSignal builtins have no throw classifications, causing the existing “every builtin says whether it can throw” test to reject them.
| "timers.setTimeoutHandle": "scr_test_mt_set_timeout_handle", | ||
| "timers.setInterval": "scr_test_mt_set_interval", | ||
| "timers.clearTimeout": "scr_test_mt_clear_timeout", | ||
| "timers.close": "scr_test_mt_clear_timeout", |
Contributor
There was a problem hiding this comment.
When only setInterval is mocked, Timeout.close() calls the timeout-specific clearer and leaves the mocked interval queued, so it continues firing after cancellation.
Comment on lines
+254
to
+255
| scr_emitter_mark_plain(view->events); | ||
| scr_worker_seed_meta_listeners(view->events); |
Contributor
There was a problem hiding this comment.
Applying NodeEventTarget semantics to Worker suppresses its listener meta-events and duplicate registrations, although Node Workers inherit EventEmitter rather than NodeEventTarget.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NodeEventTarget, itsNodeEventTargetvs.EventEmitternote, and its eleven documented listener methods from not-implemented to partial, with a Worker/MessagePort differential program (13 rows).timeout.close()to supported and pin the timer handle'sSymbol.toPrimitiveandSymbol.disposespellings with a timer corpus program (1 row status move, 3 rows of added evidence).