Repository navigation
fix(diagnostics): name the imported package and hint at a static import for uncompiled import() - #3527
Open
espetro wants to merge 2 commits into
Open
fix(diagnostics): name the imported package and hint at a static import for uncompiled import()#3527espetro wants to merge 2 commits into
espetro wants to merge 2 commits into
Conversation
Contributor
|
@espetro is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version: scriptc 0.4.11, main at 918d80b.
Repro:
scriptc build dyn.tswhere no static import namesms.Actual: the SC2013 refusal names
@types/ms(the resolved declaration package) instead ofms, and gives no way forward.Expected: the diagnostic names the package the user wrote, and hints at the fix: add a static import so the package joins the module graph, or allow a Node island.
Changes: a shared
runtimePackageNamestrips the@types/scoping,unsupportedPackageImportDiagtakes an optional hint, and the lazy import lowering passes it. Test added intests/harness/lazy-package-import.test.ts; the lazy-import, diagnostics and lower-stdlib suites pass locally (37 tests).pnpm lintcould not run in my environment (ESLint JSON parse failure); oxlint and format:check are clean.Whether literal
import("pkg")should follow into the module graph is a separate question, filed as an issue.