Repository navigation
fix(compiler): Admit setter JSDoc without optional syntax - #3359
Open
MathurAditya724 wants to merge 3 commits into
Open
MathurAditya724 wants to merge 3 commits into
MathurAditya724 wants to merge 3 commits into
Conversation
Recognize optional parameter documentation on mandatory JavaScript setters. Index attached JSDoc spans once per SourceFile and use binary containment lookup. Keep executable syntax checks, caller types, and reflective argument-count fences. Refs vercel-labs#3355 Co-Authored-By: Codex (GPT-6) <noreply@openai.com>
Contributor
|
@MathurAditya724 is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
Refresh the PR merge revision after the upstream build repair in vercel-labs#3360. Refs vercel-labs#3355 Co-Authored-By: Codex (GPT-6) <noreply@openai.com>
Refresh the PR merge revision after upstream matrix pin repairs in vercel-labs#3219 and vercel-labs#3388. Refs vercel-labs#3355 Co-Authored-By: Codex (GPT-6) <noreply@openai.com>
MathurAditya724
marked this pull request as ready for review
November 8, 2026 04:25
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accept optional parameter JSDoc on JavaScript setters whose executable parameter is mandatory. Generated bindings can document
undefinedwithout scriptc treating the comment as an optional setter parameter. Real optional/default/rest syntax, caller type checks, and reflective argument-count restrictions retain their existing diagnostics.A preflight-owned index collects attached JSDoc spans once per SourceFile and uses binary containment lookup. SourceFile identity keeps original and rewritten JSX snapshots separate when they share a filename. Regression coverage includes checked JavaScript, syntax negatives, native setter behavior, JSX offsets, and traversal growth for many setters.
Independent stock artifact and quiet timing runs against the main snapshot used by this branch passed. They cover 5,380 identical IR/LLVM/native executable comparisons, three additional identical compiler/emitter LLVM comparisons, 126 unchanged baseline refusals, and the new setter fixture. All 59 benchmark artifact hashes also match across the separate runs. The compiler's own source passes its heap, output-growth, dynamic-tier and compile-cost budgets.
Compilation measurements use Node 24.22.1 on Darwin arm64 and the stock 300-pair protocol. The 95% intervals remain below the 2% growth threshold; the self row has only one pair and no meaningful confidence interval.
Fixes #3355.