Repository navigation
fix(compiler): Clarify JavaScript refusal descriptions - #3356
Open
MathurAditya724 wants to merge 4 commits into
Open
MathurAditya724 wants to merge 4 commits into
MathurAditya724 wants to merge 4 commits into
Conversation
Explain mutable declaration bindings and distinguish them from immutable inner bindings. Describe missing target properties without assuming a Set operation. Refs vercel-labs#3354 Co-Authored-By: Codex (GPT-6) <noreply@openai.com>
Contributor
|
@MathurAditya724 is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
Refresh the PR merge revision after the upstream build repair in vercel-labs#3360. Refs vercel-labs#3354 Co-Authored-By: Codex (GPT-6) <noreply@openai.com>
Refresh the PR merge revision after the upstream stream helper repair in vercel-labs#3364. Refs vercel-labs#3354 Co-Authored-By: Codex (GPT-6) <noreply@openai.com>
Refresh the PR merge revision after upstream matrix pin repairs in vercel-labs#3219 and vercel-labs#3388. Refs vercel-labs#3354 Co-Authored-By: Codex (GPT-6) <noreply@openai.com>
MathurAditya724
marked this pull request as ready for review
November 8, 2026 04:25
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct the JavaScript refusal descriptions for mutable class and function declaration bindings, named function expression bindings, and ordinary missing-property errors. These diagnostics now explain the relevant JavaScript semantics instead of claiming that Node always throws or assuming a Set protocol.
Four regression tests exercise the real preflight output. Diagnostic codes and admission decisions remain unchanged.
Fixes #3354.