Skip to content

fix(sandbox): avoid waiting on stalled MCP startup cleanup - #2553

Open
Afloat16 wants to merge 1 commit into
vercel-labs:mainfrom
Afloat16:fix/sandbox-mcp-startup-cleanup
Open

Afloat16 wants to merge 1 commit into
vercel-labs:mainfrom
Afloat16:fix/sandbox-mcp-startup-cleanup

Conversation

@Afloat16

Copy link
Copy Markdown

Summary

When the MCP initialization request times out, startAgentBrowserMcp attempts to kill the detached Vercel command before rejecting. If that cleanup request never resolves, the configured initialization timeout never reaches the caller.

Start the cleanup request without awaiting it and keep handling cleanup rejections. The caller receives the original initialization failure while the provider processes the kill request.

Validation

The validation results below were recorded for this branch against baseline e7519957b9067c541825afa21a792fbe1f483047.

  • A stalled-kill regression fails on unchanged main because startup remains pending after the initialization timeout.
  • The regression passes with this change; a second case verifies that a rejected kill preserves the original initialization error.
  • TypeScript build and the full sandbox test suite pass: 29 tests.
  • git diff --check passes.

@vercel

vercel Bot commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

@Afloat16 is attempting to deploy a commit to the Vercel Labs Team on Vercel.

A member of the Team first needs to authorize it.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant