Repository navigation
Conversation
Contributor
|
@Afloat16 is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The sandbox MCP client treats objects with a matching ID as responses without checking their JSON-RPC shape. Missing results can resolve as successful undefined values, and a null error aborts the reader with a TypeError. Invalid initialize results can also leave a client with missing server information and locked streams.
Changes
Validate the response version, require exactly one result or error, and validate error fields before settling a request. Reject a malformed response without breaking subsequent requests. Validate server information inside the initialization cleanup boundary. Keep server requests separate from responses even when IDs overlap.
Validation
The validation results below were recorded for this branch against baseline
e7519957b9067c541825afa21a792fbe1f483047.Node v24.22.1:
node --test test/*.test.mjsinpackages/@agent-browser/sandbox: 37 tests passed.git diff --check: passed.