Repository navigation
fix(build): use the musl suffix for source-built binaries - #2471
Open
xunguangzlj-cloud wants to merge 2 commits into
Open
xunguangzlj-cloud wants to merge 2 commits into
xunguangzlj-cloud wants to merge 2 commits into
Conversation
Contributor
|
@xunguangzlj-cloud is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On a musl Linux host, the source build copies the executable to
bin/agent-browser-linux-x64. The JavaScript launcher looks forbin/agent-browser-linux-musl-x64, so it cannot start the executable the build just produced.Change
Use the launcher's existing libc detection in the copy script so both choose the same filename. The glibc and non-Linux names stay the same.
Verification
lddoutput, then run the actual copy script and launcher against a fixture executable. A Rust build on Alpine was outside this check.Authored with OpenAI Codex (GPT-6).