Repository navigation
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
lahfir
changed the title
lahfir
force-pushed
the
laf/bidi-network-emulation
branch
from
October 23, 2026 16:40
246e6a3 to
4b124fc
Compare
lahfir
force-pushed
the
laf/bidi-network-emulation
branch
from
October 23, 2026 20:45
4b124fc to
0ccffcc
Compare
lahfir
force-pushed
the
laf/bidi-network-emulation
branch
from
October 23, 2026 22:52
0ccffcc to
b4a4ab3
Compare
lahfir
force-pushed
the
laf/bidi-network-emulation
branch
from
October 23, 2026 23:21
b4a4ab3 to
c52376d
Compare
lahfir
force-pushed
the
laf/bidi-network-emulation
branch
from
October 26, 2026 20:33
c52376d to
c1aa149
Compare
lahfir
force-pushed
the
laf/bidi-network-emulation
branch
from
October 26, 2026 22:42
c1aa149 to
52314a3
Compare
ctate
approved these changes
Nov 7, 2026
The launch path opened a second RDP connection and enabled accessibility again, left over from a merge. Drop the duplicate block.
Destroyed-tab handling now lives in FirefoxSession::track_tabs, called from drain_events. network::drain resets ref and frame state when the active tab changes.
The 90 second RDP timeout only hid the hang caused by the duplicate DevTools connection, which is fixed. Go back to 30 seconds so a real hang still fails fast.
ctate
reviewed
Nov 8, 2026
ctate
approved these changes
Nov 8, 2026
…jected Update --help and the command references to describe proxy credentials as supported and keep the rejected list accurate.
ctate
approved these changes
Nov 8, 2026
ctate
approved these changes
Nov 8, 2026
ctate
approved these changes
Nov 9, 2026
Railly
reviewed
Nov 10, 2026
Railly
left a comment
Railly
left a comment
Member
There was a problem hiding this comment.
+1 to ctate's notes, will follow the rest
Moves network and emulation onto the context registry: request ownership, active-tab filtering and download waits ask it which tab a context belongs to, and unfinished requests are dropped with the contexts that owned them. Adds Firefox e2e coverage for handlers that had none: origin-scoped headers, request detail, response bodies, HAR, console and page errors, route and unroute, offline, runtime user agent, locale, geolocation and permissions. Each test was checked to fail when its handler is broken.
ctate
reviewed
Nov 11, 2026
A subscriber's queue holds 65,536 events and anything past that was dropped without a trace. The session drains its queue only when a command runs, so on a busy page a dropped `network.responseCompleted` left its request counted as unfinished for the life of the tab and later `networkidle` waits timed out. The client now records that it dropped events. The session checks that before each command and, after a drop, reads the context tree again and forgets the unfinished requests, since their completions may be among what was lost. This is the same recovery that already ran when no context was active, now one function.
ctate
approved these changes
Nov 11, 2026
| .rev() | ||
| .find(|e| e.request_id == id) | ||
| { | ||
| entry.post_data = Some(body.clone()); |
Collaborator
There was a problem hiding this comment.
The HAR path stores the body even when it is empty, unlike the tracked-request path below it, so a bodyless request records postData with "text": "" in the HAR while Chrome emits no postData block. Reproduced.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.