Extend relocatable binary support to all platforms.#613
Open
charlesstaats wants to merge 1 commit into
Open
Conversation
Move initSysdir() from settings.cc to locate.cc, alongside the rest of the file-search logic. Extend the fallback from macOS-only to all platforms: Linux uses /proc/self/exe, Windows uses GetModuleFileNameA. Add a build-tree fallback (base/ next to the executable) in addition to the install-tree fallback (../share/asymptote relative to bin/). Add ENABLE_RELOCATABLE CMake option (default off) that defines IS_RELOCATABLE; the devcontainer presets already enable it. Makefile.in: factor license-file installation into a define so copy-licenses and install-licenses share one list; add the GL shader subdirectory to uninstall-asy cleanup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some cleanups salvaged from the failed attempt to remove libatomic_ops. Relocatable binaries can be very useful for testing purposes, especially since the cmake install process is not maintained.
Move initSysdir() from settings.cc to locate.cc, alongside the rest of the file-search logic. Extend the fallback from macOS-only to all platforms: Linux uses /proc/self/exe, Windows uses GetModuleFileNameA. Add a build-tree fallback (base/ next to the executable) in addition to the install-tree fallback (../share/asymptote relative to bin/).
Add ENABLE_RELOCATABLE CMake option (default off) that defines IS_RELOCATABLE; the devcontainer presets already enable it.
Makefile.in: factor license-file installation into a define so copy-licenses and install-licenses share one list; add the GL shader subdirectory to uninstall-asy cleanup.