String brackets - #603
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds first-class s[pos] indexing support for string, enabling access to length-one substrings via operator[] (including negative indices) and documenting + testing the new behavior.
Changes:
- Add
string.operator[]as a virtual field on the primitivestringtype, withintkey type support for subscripting. - Implement the runtime builtin backing
stringBrackets(with negative-index handling and out-of-range returning empty string). - Add a dedicated test and update the manual to describe
s[pos]behavior.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
types.h |
Adds overrides and a primitiveTy::keyType() override needed for string subscripting. |
types.cc |
Wires operator[] for string as a virtual field and implements primitiveTy::keyType() for string. |
runstring.in |
Implements the runtime thunk/helper used to execute string.operator[]. |
exp.cc |
Updates subscript expression type inference to treat string indexing as string. |
tests/datastructures/stringBracketsTest.asy |
Adds coverage for positive/negative/out-of-range indexing and signature checks. |
doc/asymptote.texi |
Documents s[pos] indexing semantics and adds index entries for operator[]. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Access length-one substrings via the notation
s[pos], wheresis a string andposis an integer.