Skip to content

Give each top-level class's methods a lobby off the module hub - #19

Merged
valuecodes merged 3 commits into
mainfrom
feat/class-lobbies
Oct 10, 2026
Merged

valuecodes merged 3 commits into
mainfrom
feat/class-lobbies

Conversation

@valuecodes

Copy link
Copy Markdown
Owner

What

  • Part 5/7 of Code Backrooms Phase 4 (multi-file repositories): class lobbies. A class's methods used to crowd the module hub, one door each. Now a top-level class's methods that hang off the hub open off a lobby room (class UserService), which takes one door of the hub. More lobbies chain on past the door budget (m.ts//class:Svc#2). Methods reached by a call door keep that door, and returns still land at the module hub.
  • The parser records class declarations as ClassNodes in CodeGraph.classes: id file.ts//class:Name (~2 on a repeated name, such as declarations in two branches), span, exported and topLevel. // can never appear in a normalised path, so a lobby id can't collide with any module.
  • Hub planning moves to packages/code-graph/src/hub-plan.ts. parseHubId reads any hub id back as { module, classId, index }. roomSubject gives { kind: "class", module, node, methods } for a lobby.
  • The HUD reads service.ts · class UserService, the door prompt reads → class UserService, and the source panel shows the whole class.

How to test

pnpm typecheck
pnpm lint
pnpm knip
pnpm test
pnpm build
pnpm --filter web dev   # http://localhost:3000/?code=service: hub → class UserService → load

Security review

No security-impacting changes.

🤖 Generated with Claude Code

valuecodes and others added 2 commits October 10, 2026 22:24
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings October 10, 2026 19:27

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-10T19:29:52.429876Z 4b9ad9a PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4b9ad9a169

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/parser/src/functions.ts Resolved
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@valuecodes
valuecodes merged commit 37ba611 into main Oct 10, 2026
10 checks passed
@valuecodes
valuecodes deleted the feat/class-lobbies branch October 10, 2026 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants