du: deduplicate Stat::new call #10584
Open
+21
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GNU testsuite comparison: |
ChrisDryden
reviewed
Jan 31, 2026
| my_stat: Option<std::io::Result<Stat>>, | ||
| ) -> Result<Stat, Box<mpsc::SendError<UResult<StatPrintInfo>>>> { | ||
| // Get initial stat for this path - use DirFd if available to avoid path length issues | ||
| let mut my_stat = if let Some(parent_fd) = parent_fd { |
Collaborator
There was a problem hiding this comment.
This is a bit confusing to read, my_stat is immediately shadowed at the beginning of the function. Maybe it would be better to change the naming of it to indicate the difference between the two?
Contributor
Author
There was a problem hiding this comment.
I agree, it would be better to change the name. I thought about that too.
Renamed
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the review comment from another PR by @ChrisDryden:
Apologies for the long delay. I didn't have an opportunity to address it earlier.