Skip to content

Conversation

@oech3
Copy link
Contributor

@oech3 oech3 commented Jan 15, 2026

Fixes #10244
Also covers some (but no all of) use case for symlinking binary to /bin/false.

@oech3 oech3 marked this pull request as draft January 15, 2026 08:31
@github-actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/env/env. tests/env/env is passing on 'main'. Maybe you have to rebase?

@oech3 oech3 force-pushed the core-1 branch 3 times, most recently from e9b9baa to ddd1f27 Compare January 15, 2026 08:55
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 15, 2026

CodSpeed Performance Report

Merging this PR will degrade performance by 27.39%

Comparing oech3:core-1 (0d4378d) with main (f2bec7b)1

Summary

❌ 13 regressed benchmarks
✅ 269 untouched benchmarks
⏩ 38 skipped benchmarks2

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Memory numfmt_to_si[10000] 4.7 MB 5 MB -4.92%
Memory numfmt_round_modes[("up", 10000)] 4.8 MB 4.9 MB -3.16%
Memory numfmt_to_si_precision[10000] 4.6 MB 4.8 MB -3.2%
Simulation numfmt_to_iec[10000] 34 ms 35.1 ms -3.21%
Simulation numfmt_to_si[10000] 34 ms 35.1 ms -3.24%
Simulation numfmt_from_si[10000] 32.6 ms 33.7 ms -3.27%
Memory sort_numeric[500000] 75.5 MB 79.2 MB -4.66%
Memory sort_unique_locale[500000] 33.6 MB 39.8 MB -15.51%
Memory sort_accented_data[500000] 22.1 MB 28.3 MB -21.79%
Memory sort_ascii_only[500000] 22.2 MB 28.3 MB -21.77%
Memory sort_mixed_data[500000] 22.9 MB 27.1 MB -15.71%
Memory sort_key_field[500000] 47.8 MB 51.8 MB -7.62%
Memory sort_long_line[160000] 712.6 KB 981.4 KB -27.39%

Footnotes

  1. No successful run was found on main (571e139) during the generation of this report, so f2bec7b was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 38 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/env/env. tests/env/env is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)

@github-actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/env/env. tests/env/env is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/shuf/shuf-reservoir (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/sort/sort-stale-thread-mem (fails in this run but passes in the 'main' branch)

@github-actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/env/env. tests/env/env is passing on 'main'. Maybe you have to rebase?

@oech3 oech3 marked this pull request as ready for review January 15, 2026 10:43
Some(OsString::from(util))
} else {
// unmatched binary name => regard as multi-binary container and advance argument list
} else if binary_as_util.ends_with("coreutils") || binary_as_util.ends_with("box") {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like to have .ends_with("box") in the binary just for test suite. Should be covered by shebang wrapper (at different PR).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shebang does not work...

@oech3 oech3 force-pushed the core-1 branch 2 times, most recently from 572a08f to a7da462 Compare January 15, 2026 16:07
@oech3 oech3 changed the title coreutils: Fail with invalid binary name tests/misc/coreutils.sh: Fail with invalid binary name Jan 15, 2026
@oech3 oech3 force-pushed the core-1 branch 7 times, most recently from 657c5e7 to f7625bd Compare January 16, 2026 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

coreutils: Unknown program should fail (tests/misc/coreutils.sh)

2 participants