tail: Handle missing/dir paths via metadata() #10220
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xylphy
changed the title
Add Unix-only tests covering the case where probing a path (e.g. via metadata) fails with PermissionDenied (directory not searchable). Ensure we report "Permission denied" rather than "No such file or directory", matching GNU tail.
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10193
This pull request refactors error handling in the
tail_filefunction insrc/uu/tail/src/tail.rsto usepath.metadata()for file checks and improves error reporting formatting.Error handling and logic improvements:
path.metadata(), enabling more robust detection of missing files and directories. This replaces separate checks for existence and directory status with a single match statement.ErrorKind::NotFoundto ensure missing files are reported with the correct error message and observer update, then exit early.Error reporting formatting:
translate!calls for better readability and consistency across permission and file opening errors.