Refactor DockerCLI for console 0.2 commands#66
Conversation
Greptile SummaryThis PR migrates Confidence Score: 5/5Safe to merge — all prior review concerns are addressed and no new issues were found Every changed method uses the structured Command API correctly, the three previously raised bugs (normalizeCommandArgument, label single-quote strip, screen argv) have been fixed, the new O'Brien label regression test is well-formed, and a subtle old bug (escapeshellarg treating '0' as empty) is incidentally corrected. No P0/P1 findings remain. No files require special attention Important Files Changed
Reviews (3): Last reviewed commit: "Fix structured command regressions" | Re-trigger Greptile |
|
@greptile-apps please review the latest commit on this PR. |
|
@greptile-apps please review the latest commit on this PR (49a86d9). The screen argv regression is fixed, label quote stripping is removed, and a regression test was added for labels containing single quotes. |
Summary
utopia-php/consoleto0.2.*and refresh the lockfileDockerCLIfrom shell-string execution to structuredUtopia\CommandusageValidation
./vendor/bin/pint --test./vendor/bin/phpstan analyse --level 6 src tests./vendor/bin/phpunit --configuration phpunit.xml tests/Orchestration/Adapter/DockerCLITest.php(fails locally because the test setup expects/usr/src/code/tests/Orchestration/Resources, which is not present in this workspace; opening the PR to run CI in the intended environment)