Update fetch dependency#115
Conversation
Greptile SummaryThis PR updates the
Confidence Score: 5/5Minimal-scope dependency bump; no application code was changed and the updated lock file correctly pins the new version. The change is limited to a version constraint update in composer.json and the corresponding lock-file refresh. No logic, tests, or other dependencies were modified, and the diff is mechanically straightforward. No files require special attention. Important Files Changed
Reviews (2): Last reviewed commit: "Refresh Greptile review" | Re-trigger Greptile |
| "php": ">=8.4", | ||
| "utopia-php/database": "5.*", | ||
| "utopia-php/fetch": "0.5.*", | ||
| "utopia-php/fetch": "^1.1", |
There was a problem hiding this comment.
Incomplete API surface verified for the version bump
The PR description confirms Client::fetch(), Response::getStatusCode(), and Response::getBody() are present in 1.1.2, but ClickHouse.php also calls $client->addHeader(), $client->setTimeout(), and references the Client::METHOD_POST constant. The README for the 1.x branch confirms addHeader(), but setTimeout() and METHOD_POST aren't explicitly covered. If either was removed or renamed between 0.5.x and 1.1.x, the ClickHouse adapter will throw a fatal error at construction time for every caller.
Summary
utopia-php/fetchconstraint from0.5.*to^1.1.composer.lockto installutopia-php/fetch1.1.2.Compatibility
auditusesUtopia\Fetch\Client,Client::setTimeout(),Client::fetch(),Client::METHOD_POST,Response::getStatusCode(), andResponse::getBody()insrc/Audit/Adapter/ClickHouse.php. These symbols are still available infetch1.1.2.Test Plan
composer validate --strictcomposer run lint./vendor/bin/phpstan analyse --level max src tests --memory-limit=512MNotes:
composer auditreports the existinggoogle/protobufadvisory on the default dependency set; this PR only changesutopia-php/fetch.vendor/bin/phpunitrequires localclickhouseandmariadbhostnames and fails in this environment because those services are not available.