Skip to content

updated fetch#20

Closed
ArnabChatterjee20k wants to merge 3 commits intomainfrom
chore-bump-fetch
Closed

updated fetch#20
ArnabChatterjee20k wants to merge 3 commits intomainfrom
chore-bump-fetch

Conversation

@ArnabChatterjee20k
Copy link
Copy Markdown
Contributor

@ArnabChatterjee20k ArnabChatterjee20k commented Jan 13, 2026

Summary by CodeRabbit

  • Chores
    • Updated an internal library dependency to a newer compatible version.
  • Bug Fixes
    • Increased the default request timeout for the Ollama adapter to reduce premature timeouts during embeddings and related operations.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jan 13, 2026

Walkthrough

composer.json: bumped dependency constraint for utopia-php/fetch from 0.4.* to 0.5.*.
src/Agents/Adapters/Ollama.php: changed default constructor timeout from 90 to 60000, updating the public constructor signature to __construct(string $model = self::MODEL_EMBEDDING_GEMMA, int $timeout = 60000).
tests/Agents/AgentTest.php: adjusted a test timeout from 10000 to 60000. No other logic or error-handling changes.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title 'updated fetch' is partially related to the changeset but fails to capture the full scope of changes, which include timeout adjustments alongside the fetch dependency bump. Consider a more specific title like 'Bump utopia-php/fetch to 0.5.* and adjust Ollama timeout settings' to better reflect all significant changes in the pull request.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@abnegate abnegate closed this Apr 29, 2026
@abnegate abnegate deleted the chore-bump-fetch branch April 29, 2026 06:50
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 29, 2026

Greptile Summary

This PR changes the utopia-php/fetch version constraint in composer.json from ^1.1.0 to 1.*. Rather than updating to a newer version, this widens the allowed range to include 1.0.x releases that were previously excluded, which may allow resolution to versions lacking APIs the codebase depends on.

Confidence Score: 3/5

Not safe to merge as-is — the constraint relaxation may allow resolution to older 1.0.x versions that could cause runtime failures.

A single P1 finding: the minimum version floor is lowered from 1.1.0 to 1.0.0, which can silently break installations that resolve to a 1.0.x release missing APIs (e.g. setTimeout) used in the codebase.

composer.json — the only changed file and the source of the concern.

Important Files Changed

Filename Overview
composer.json Dependency constraint for utopia-php/fetch changed from ^1.1.0 to 1.*, widening the allowed range to include 1.0.x versions that were previously excluded and may lack required APIs.

Reviews (1): Last reviewed commit: "Merge branch 'main' into chore-bump-fetc..." | Re-trigger Greptile

Comment thread composer.json
"require": {
"php": ">=8.3",
"utopia-php/fetch": "^1.1.0"
"utopia-php/fetch": "1.*"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Version constraint relaxes minimum, not raises it

Changing from ^1.1.0 to 1.* widens the allowed range from >=1.1.0 <2.0.0 to >=1.0.0 <2.0.0. This means Composer can now resolve to 1.0.x versions that were previously excluded. If any API used in this codebase (such as Client::setTimeout(), which the Ollama adapter relies on) was introduced in 1.1.0, installations resolving to 1.0.x will encounter runtime errors.

Suggested change
"utopia-php/fetch": "1.*"
"utopia-php/fetch": "^1.1.0"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants