-
Notifications
You must be signed in to change notification settings - Fork 82
Remove obsolete functions #2616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2616 +/- ##
=======================================
Coverage 46% 46%
- Complexity 6643 6659 +16
=======================================
Files 793 794 +1
Lines 65719 65746 +27
Branches 9844 9852 +8
=======================================
+ Hits 30602 30629 +27
+ Misses 32759 32754 -5
- Partials 2358 2363 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
feb2812 to
745a65f
Compare
|
@PaulKlint Can you please confirm which of the copies should remain? |
745a65f to
8039269
Compare
PaulKlint
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See remarks. It is fine to remove these functions.
src/org/rascalmpl/compiler/lang/rascalcore/check/tests/StaticTestingUtils.rsc
Outdated
Show resolved
Hide resolved
PaulKlint
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, except extend in StaticTestingUtils
|
This needs the changes pending in usethesource/typepal#34 |
f997255 to
70eec9e
Compare
Remove some functions, copies of which also exist here:
https://github.com/usethesource/typepal/blob/60cb6ea4febf0bf1152ec0d81279ebacc7beaaf6/src/analysis/typepal/Collector.rsc#L35-L40