added more tests with hashCode=0 collisions#41
Closed
jurgenvinju wants to merge 1 commit intomainfrom
Closed
Conversation
Member
Author
Member
|
The information provided in this PR, describing the observed behaviour, expedited triaging and fixing the underlying issue in #42. Closing this PR in favour of #42, which suggests that there is already sufficient coverage in the property-based test suite to trigger the observed behaviour. After adding the invariant explicitly, the suite exhibited failures. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

I'm debugging some issues with relation and map key removal on the vallang level and rascal level. They all relate to hashCode=0 collisions so I added some tests here to rule out a bug in capsule.