Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #89 and more Jumplist related issues. An alternative approach to #98 . It utilizes pre-execution "hooks" to add more
Jumplistpoints. I'm not sure which approach is better.This PR is more a question/discussion than a contribution. This approach sacrifices a small performance penalty. However, I think it's better than sprinkling changes to upstream code. Moreover, it will simplify adding more features later on without touching upstream (beside adding one call in the command executor). What do you think? I'm also not sure if using strings is ok, but it makes the code smaller.
Note: I still need to check what Jumplist points we are missing, this is still a draft.