-
Notifications
You must be signed in to change notification settings - Fork 26
feat(config): pass rlimits to urunit via UCS #353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for urunc canceled.
|
|
@cmainas Can you guide me why these two test cases are getting failed? |
These are both linting errors, because of spelling. I think updating https://github.com/urunc-dev/urunc/blob/main/.github/linters/urunc-dict.txt should be enough.
|
8d58b89 to
fb24736
Compare
This extracts the rlimits from the OCI spec in the unikontainer logic and appends them to the UCS configuration block generated in linux.go. This allows the guest init process (urunit) to enforce resource limits. Signed-off-by: Sankalp <[email protected]>
fb24736 to
be0d065
Compare
|
cmainas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @codesmith25103 , in order for these changes to be effective, we also need to update urunit to parse the updated config and apply the rlimits to the process. Therefore, we can not merge this without urunit supporting them. If you want you can also try to implement the necessary changes in urunit too. Otherwise, I will work on it when I find time to do so.
|
@cmainas I will try to update urunit and will update this PR. |



feat(unikernels): pass rlimits to urunit via UCS
This adds support for passing rlimits from the OCI spec to the
guest VM by appending them to the UCS configuration block.
Fixes #312