Conversation
Normalize every epoch (debug clock, resets, update state, lock age) before it reaches arithmetic, so a malformed value degrades instead of breaking countdown and throttle math. Write all state files (rate-limit cache, last_check, remote_version) through private mktemp+mv swaps: modes go 0600, planted symlinks and non-empty directories are refused, an empty planted directory is rmdir-healed. Adds 15 test cases covering the new behavior.
perm_case probed BSD-first, but GNU stat treats -f as filesystem status: it emits noise while failing, so the captured mode was garbage and all four permission cases failed on Linux. Probe GNU-first like the renderer's held_at check. The same Linux run exposed a latent flake: piping into grep -q under pipefail dies with SIGPIPE when grep exits at an early match. Replace the four pipelines with herestrings. Static cases now pin both conventions so either platform catches them at author time.
An idle session's hours-old percentage shares the live reset epoch, so the non-regressing-reset guard admitted it and overwrote the fresh reading. The window guard is now reset-keyed: a newer reset takes the incoming pair whole, an equal reset keeps the higher percentage, and an older reset never replaces the cached pair. Every writer applies the same rule, so the unlocked write race converges. written_at stays "last touched". observed_at moves only when an effective percentage changes, so consumers can spot a stale value. Schema bumps to 2; consumers read named keys and are unaffected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.