nice interface -- I tested it with Homeworks QS#1
Open
dulitz wants to merge 7 commits into
Open
Conversation
…the integration JSON. Add some constants used by Homeworks QS.
…O and Radio Ra2 Select; for others the integrator can turn it on
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That inspired me to a few code cleanups, and I added some login error detection.
I noticed you had marked the project as Python 3.6-or-later, so I changed the strings to f-strings.
This is a sweet interface, and I have to say a big thank you because I've worked with LIP before but I had no idea what the Radio Ra2 Select default login credentials were, nor did I know that it used LIP.