Skip to content

Harden account access, privacy, billing, and web delivery - #417

Merged
lunarthegrey merged 18 commits into
mainfrom
codex/security-scan-remediations
Nov 18, 2026
Merged

lunarthegrey merged 18 commits into
mainfrom
codex/security-scan-remediations

Conversation

@lunarthegrey

Copy link
Copy Markdown
Contributor

Changes

This PR groups 17 security fixes into one commit per finding. The commits include the corresponding regression tests and deployment notes.

  • Account access and invitations. Bind passkey login to the session signing key. Require a fresh member session for permanent credential changes, enforce subscription-read permission for proxy credentials, and invalidate overlapping logins on account-number rotation. Encrypt admin invitation redemption and invalidate superseded invitations.
  • Privacy and diagnostics. Retire earlier subscription links by default when switching to Privacy. Members can explicitly keep those links during the switch. Encrypt diagnostic details before submission and separate diagnostic events from member audit records.
  • Billing and provider credentials. Bind billing, Remnawave, and alert credentials to their configured destinations, and apply the destination policy to backend connection tests. Bound the work done before authenticating NOWPayments callbacks and require a completed, matching PayPal capture before granting membership.
  • Browser delivery. Authorize the generated integrity import map under the production Content Security Policy and preserve the browser sandbox for subscription responses served through Caddy.

Upgrade notes

Deploy the origin changes first, then refresh the web client. Reissue pending admin invitations using a client built with the server encryption key pinned. For existing sandbox or self-hosted billing configurations, confirm the deployment API base matches the intended endpoint or re-enter the credentials for that endpoint. The billing and privacy docs describe the credential migration and cleanup of older diagnostic records.

Validation

The 100 files changed by this branch match the applied remediation patches byte for byte. Type checking, the Convex bundle check, lint, the full test suite, and the production build passed locally. The test suite reported 7,164 passes, one expected failure, and one TODO. The CI workflow also exercises the production web image and the Caddy subscription response policy.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-18T17:00:34.436076Z 738f37c PR opened
🔒 Security Review ✅ Completed 2026-11-18T17:03:31.766889Z 738f37c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Docker's port proxy accepts the connection before Caddy listens and then
resets it. --retry-connrefused does not cover a reset, so curl gave up on
the first attempt.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@lunarthegrey
lunarthegrey merged commit 7c3a446 into main Nov 18, 2026
41 checks passed
@lunarthegrey
lunarthegrey deleted the codex/security-scan-remediations branch November 18, 2026 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant