Skip to content

fix(terminal): backport OpenTerminal input validation to 7.3 - #2763

Merged
tom mortensen (limetech) merged 3 commits into
unraid:7.3from
SimonFair:fix/openterminal-input-validation-7-3
Sep 22, 2026
Merged

tom mortensen (limetech) merged 3 commits into
unraid:7.3from
SimonFair:fix/openterminal-input-validation-7-3

Conversation

@SimonFair

Copy link
Copy Markdown
Contributor

Summary

  • Validate OpenTerminal request parameters before use.
  • Quote command arguments at shell boundaries.
  • Validate plugin-manager branch substitutions.

@coderabbitai

coderabbitai Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: 3e857360-8e1d-4a33-8d04-364290ed090d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

🔧 PR Test Plugin Available

A test plugin has been generated for this PR that includes the modified files.

Version: 2026.09.22.0740
Build: View Workflow Run

📥 Installation Instructions:

Install via Unraid Web UI:

  1. Go to Plugins → Install Plugin
  2. Copy and paste this URL:
https://preview.dl.unraid.net/pr-plugins/pr-2763/webgui-pr-2763.plg
  1. Click Install

Alternative: Direct Download

⚠️ Important Notes:

  • Testing only: This plugin is for testing PR changes
  • Backup included: Original files are automatically backed up
  • Easy removal: Files are restored when plugin is removed
  • Conflicts: Remove this plugin before installing production updates
  • Post-merge behavior: This preview stays available after merge until preview storage expires or it is manually cleaned up

📝 Modified Files:

Click to expand file list
emhttp/plugins/dynamix.plugin.manager/include/ShowPlugins.php
emhttp/plugins/dynamix/include/OpenTerminal.php

🔄 To Remove:

Navigate to Plugins → Installed Plugins and remove webgui-pr-2763, or run:

plugin remove webgui-pr-2763

🤖 This comment is automatically generated and will be updated with each new push to this PR.

@unraid-bot Unraid Bot (unraid-bot) added QA Ready Ready for QA (auto-managed by notification-worker) QA Passed QA passed (auto-managed by notification-worker) 7.3.3 Approved for release 7.3.3 (auto-managed by notification-worker) and removed QA Ready Ready for QA (auto-managed by notification-worker) labels Sep 22, 2026
@limetech
tom mortensen (limetech) merged commit 204309c into unraid:7.3 Sep 22, 2026
2 checks passed
@unraid-bot Unraid Bot (unraid-bot) removed 7.3.3 Approved for release 7.3.3 (auto-managed by notification-worker) labels Sep 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

QA Passed QA passed (auto-managed by notification-worker)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants