Skip to content

Conversation

@craciunoiuc
Copy link
Member

Prerequisite checklist

  • Read the contribution guidelines regarding submitting new changes to the project;
  • Tested your changes against relevant architectures and platforms;
  • Ran make fmt on your commit series before opening this PR;
  • Updated relevant documentation.

Description of changes

@craciunoiuc craciunoiuc requested a review from nderjung September 6, 2024 07:11
@craciunoiuc craciunoiuc force-pushed the craciunoiuc/add-more-instance-tests branch from 3c2277d to bc12299 Compare September 6, 2024 11:42
@craciunoiuc craciunoiuc changed the title feat: Add tests for rest of instance commands & fix issues feat: Add more tests & fix issues found by them Sep 13, 2024
@craciunoiuc craciunoiuc force-pushed the craciunoiuc/add-more-instance-tests branch 6 times, most recently from 3831109 to 66001bd Compare September 18, 2024 15:26
@craciunoiuc
Copy link
Member Author

craciunoiuc commented Sep 19, 2024

TODO: wait_timeout_ms to be renamed to timeout_s

Need to change commit: 8903b43

Edit: Once @marcrittinghaus updates nodes we can do this, it will be backwards compatible until then

@craciunoiuc craciunoiuc force-pushed the craciunoiuc/add-more-instance-tests branch 2 times, most recently from d72134e to 37dac91 Compare January 15, 2025 10:44
@craciunoiuc craciunoiuc force-pushed the craciunoiuc/add-more-instance-tests branch from 37dac91 to 032156f Compare January 21, 2025 13:25
@craciunoiuc craciunoiuc changed the title feat: Add more tests & fix issues found by them feat(test): Add more cloud tests Jan 21, 2025
Also add test fixtures for working with cpio archives.

Signed-off-by: Cezar Craciunoiu <[email protected]>
This still needs rebasing to break the changes of this
commit up and merge in the corresponding commits.

Signed-off-by: Cezar Craciunoiu <[email protected]>
@craciunoiuc craciunoiuc force-pushed the craciunoiuc/add-more-instance-tests branch from 032156f to 5704c51 Compare July 3, 2025 14:49
@craciunoiuc
Copy link
Member Author

tagging @mdsahiloss as somehow I can't add you as a reviewer 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant