Inflection-179: Update ICU dependency and Wikidata processing #180
Conversation
| TEST_CASE("NumberConceptTest#testSwiss") | ||
| { | ||
| REQUIRE(u"1’000" == ::inflection::dialog::NumberConcept((int64_t)1000, ::inflection::util::LocaleUtils::SWITZERLAND_GERMAN(), ::inflection::util::LocaleUtils::SWITZERLAND_GERMAN()).getAsDigits().getPrint()); | ||
| REQUIRE(u"1'000" == ::inflection::dialog::NumberConcept((int64_t)1000, ::inflection::util::LocaleUtils::SWITZERLAND_GERMAN(), ::inflection::util::LocaleUtils::SWITZERLAND_GERMAN()).getAsDigits().getPrint()); |
There was a problem hiding this comment.
Required by ICU 78.1 used by macOS GitHub action.
| auto numID = npc(inflectionDictionary)->getId(value); | ||
| if (numID == -1) { | ||
| throw inflection::exception::IllegalStateException(std::u16string(value) + u" inflection name not found."); | ||
| } |
There was a problem hiding this comment.
Safety check in case things get out of sync.
| TYPEMAP.put("Q3734650", EnumSet.of(Ignorable.IGNORABLE_LEMMA)); // adverbial phrase, a phrase the head of which is an adverb | ||
| TYPEMAP.put("Q357760", EnumSet.of(Ignorable.IGNORABLE_LEMMA)); // adjectival phrase | ||
| TYPEMAP.put("Q56042915", EnumSet.of(Ignorable.IGNORABLE_LEMMA)); // prepositional phrase | ||
| TYPEMAP.put("Q3397768", EnumSet.of(Ignorable.IGNORABLE_LEMMA)); // prepositional phrase/prepositional syntagma |
There was a problem hiding this comment.
This got renamed in Wikidata.
| # | ||
| CATCH2_VERSION := 3.9.0 | ||
| ICU_VERSION_MINIMUM := 77.1 | ||
| ICU_VERSION_MINIMUM := 78.1 |
There was a problem hiding this comment.
Get Linux and macOS to use the same version.
|
The github workflow is installing ICU of 77.1 release that is why this is occurring, please consider updating |
grhoten
force-pushed
the
main
branch
2 times, most recently
from
b09ec7d to
c931a6c
Compare
|
@BHK4321 I included part of your libxml2 change into this pull request. I also updated the ICU dependency so that the pull request checks pass again. These changes still have the following linker warning, but it's fewer than before. |
3 participants
Fixes #179